operator: explicitly check sync errors to set Available status

The most common sync error that was see is RequiredPoolsFailed,
which does not mean that the operator itself is impaired. Let's
only set Available = False when operand syncs fail.

pkg/operator/status.go

@@ -91,7 +91,7 @@ func (optr *Operator) syncRelatedObjects() error {
 }
 
 // syncAvailableStatus applies the new condition to the mco's ClusterOperator object.
-func (optr *Operator) syncAvailableStatus() error {
+func (optr *Operator) syncAvailableStatus(ierr syncError) error {
 	co, err := optr.fetchClusterOperator()
 	if err != nil {
 		return err
@@ -100,12 +100,13 @@ func (optr *Operator) syncAvailableStatus() error {
 		return nil
 	}
 
-	degraded := cov1helpers.IsStatusConditionTrue(co.Status.Conditions, configv1.OperatorDegraded)
 	message := fmt.Sprintf("Cluster has deployed %s", co.Status.Versions)
-
 	available := configv1.ConditionTrue
 
-	if degraded {
+	// we will only be Available = False where there is a problem syncing
+	// operands of the MCO as that points to impaired operator functionality.
+	// RequiredPools failing but everything else being ok, should be just Degraded = True.
+	if ierr.err != nil && ierr.task != "RequiredPools" {
 		available = configv1.ConditionFalse
 		mcoObjectRef := &corev1.ObjectReference{
 			Kind:      co.Kind,

pkg/operator/sync.go

@@ -84,7 +84,7 @@ func (optr *Operator) syncAll(syncFuncs []syncFunc) error {
 		return fmt.Errorf("error syncing degraded status: %v", err)
 	}
 
-	if err := optr.syncAvailableStatus(); err != nil {
+	if err := optr.syncAvailableStatus(syncErr); err != nil {
 		return fmt.Errorf("error syncing available status: %v", err)
 	}