mco: set co status upgradeable to false while pools updating

Sets machine-config clusteroperator Upgradeable: False when pools are updating (covering future upgrades),
does not block current upgrade from reporting finished on all completing.

When pools are both Updating and Degraded, we prioritize reporting Degraded:
If any pool is Degraded, the clusteroperator status.Reason == DegradedPool.
Otherwise, if any pool is Updating (but none are Degraded) status.Reason == PoolUpdating.

pkg/operator/status.go

@@ -262,14 +262,27 @@ func (optr *Operator) syncUpgradeableStatus() error {
 		Status: configv1.ConditionTrue,
 		Reason: asExpectedReason,
 	}
+	var updating, degraded bool
 	for _, pool := range pools {
-		degraded := isPoolStatusConditionTrue(pool, mcfgv1.MachineConfigPoolDegraded)
+		// collect updating status but continue to check each pool to see if any pool is degraded
+		if isPoolStatusConditionTrue(pool, mcfgv1.MachineConfigPoolUpdating) {
+			updating = true
+		}
+		degraded = isPoolStatusConditionTrue(pool, mcfgv1.MachineConfigPoolDegraded)
+		// degraded should get top billing in the clusteroperator status, if we find this, set it and update
 		if degraded {
 			coStatus.Status = configv1.ConditionFalse
 			coStatus.Reason = "DegradedPool"
-			coStatus.Message = "One or more machine config pool is degraded, please see `oc get mcp` for further details and resolve before upgrading"
+			coStatus.Message = "One or more machine config pools are degraded, please see `oc get mcp` for further details and resolve before upgrading"
+			break
 		}
 	}
+	// updating and degraded can occur together, in that case defer to the degraded Reason that is already set above
+	if updating && !degraded {
+		coStatus.Status = configv1.ConditionFalse
+		coStatus.Reason = "PoolUpdating"
+		coStatus.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
+	}
 
 	return optr.updateStatus(co, coStatus)
 }