controller: err check before log/event success for renderedcfg creation

kikisdeliveryservice · May 24, 2021 · 070be26 · 070be26
1 parent 54e68f7
commit 070be26
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/controller/render/render_controller.go b/pkg/controller/render/render_controller.go
@@ -495,6 +495,9 @@ func (ctrl *Controller) syncGeneratedMachineConfig(pool *mcfgv1.MachineConfigPoo
 	_, err = ctrl.mcLister.Get(generated.Name)
 	if apierrors.IsNotFound(err) {
 		_, err = ctrl.client.MachineconfigurationV1().MachineConfigs().Create(context.TODO(), generated, metav1.CreateOptions{})
+		if err != nil {
+			return err
+		}
 		glog.V(2).Infof("Generated machineconfig %s from %d configs: %s", generated.Name, len(source), source)
 		ctrl.eventRecorder.Eventf(pool, corev1.EventTypeNormal, "RenderedConfigGenerated", "%s successfully generated", generated.Name)
 	}