Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v2.1.0) Support for non-integer user_ids #17

Merged
merged 9 commits into from
May 24, 2020
Merged

(v2.1.0) Support for non-integer user_ids #17

merged 9 commits into from
May 24, 2020

Conversation

kigster
Copy link
Owner

@kigster kigster commented May 23, 2020

  • Adding a non-integer user_id unit test, which is failing as expected.

@kigster kigster marked this pull request as draft May 23, 2020 08:28
@kigster kigster self-assigned this May 23, 2020
@kigster kigster linked an issue May 23, 2020 that may be closed by this pull request
Support string or UUID user_id across the board #16
Closed
@kigster kigster mentioned this pull request May 23, 2020
Closed
@kigster kigster linked an issue May 23, 2020 that may be closed by this pull request
Base62 encoding for @user_id is problematic for namespacing #11
Closed
@kigster kigster force-pushed the v2.1.0-alpha branch 2 times, most recently from 6b67d35 to 7b1c268 Compare May 23, 2020 08:44
@kigster
WIP: 2.1.0-alpha — support for non-integer user_ids
a04449c 
 * Adding a non-integer user_id unit test, which is failing as expected.
@kigster kigster marked this pull request as ready for review May 24, 2020 10:08
@kigster kigster merged commit be968a6 into master May 24, 2020
@kigster kigster deleted the v2.1.0-alpha branch May 24, 2020 10:08
@kigster kigster changed the title WIP: 2.1.0-alpha — support for non-integer user_ids (v2.1.0) Support for non-integer user_ids May 24, 2020
@kigster kigster restored the v2.1.0-alpha branch May 24, 2020 10:12
@rromanchuk
Copy link
Contributor

@kigster awesome. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kigster kigster

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support string or UUID user_id across the board Base62 encoding for @user_id is problematic for namespacing
2 participants
@kigster @rromanchuk