Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure how this is working for everyone else? #15

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

rromanchuk
Copy link
Contributor

I'm not able to boot rails without this require. Hashie.logger = Logger.new(nil) throws simplefeed.rb:4:in

': undefined method logger=' for Hashie:Module (NoMethodError) That line has been around for an extremely long time, so clearly there is something unique to my environment. Sending PR for visibility. I'll step through my boot and try to figure out what went wrong with loading.

Rails 6.0.2.2
ruby 2.7.0p0
simple-feed (2.0.2)

I'm not able to boot rails without this require.  `Hashie.logger = Logger.new(nil)`  throws `simplefeed.rb:4:in `<main>': undefined method `logger=' for Hashie:Module (NoMethodError)`  That line has been around for an extremely long time, so clearly there is something unique to my environment. Sending PR for visibility. I'll step through my boot and try to figure out what went wrong with loading.

```
Rails 6.0.2.2
ruby 2.7.0p0
simple-feed (2.0.2)
```
@kigster
Copy link
Owner

kigster commented Apr 28, 2020

Thanks for submitting this PR!

I bet Hashie changed downstream and now only the top level file defines logger.

In any case, appreciate your contribution! Keep them coming :)

@kigster kigster merged commit 369da05 into kigster:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants