Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workaround for broken sqlx::test macro #315

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

praseodym
Copy link
Contributor

sqlx 0.8.0 broke the path functionality of the sqlx::test macro, so we implemented a workaround in #205. sqlx 0.8.2 fixes the macro (launchbadge/sqlx#3403), and now that we have upgraded (#314) we can undo our workaround.

@praseodym praseodym requested a review from a team as a code owner September 9, 2024 07:47
@praseodym praseodym requested review from lkleuver, cikzh, Lionqueen94 and jschuurk-kr and removed request for a team September 9, 2024 07:47
@praseodym praseodym self-assigned this Sep 9, 2024
@praseodym praseodym added the backend Issues or pull requests that relate to the backend label Sep 9, 2024
@praseodym praseodym enabled auto-merge September 9, 2024 07:47
@praseodym praseodym added this pull request to the merge queue Sep 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 9, 2024
@praseodym praseodym added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 99159de Sep 9, 2024
7 checks passed
@praseodym praseodym deleted the revert-sqlx-test-macro-workaround branch September 9, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues or pull requests that relate to the backend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants