Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few mssql tests #1

Draft
wants to merge 33 commits into
base: mssql
Choose a base branch
from
Draft

Fix a few mssql tests #1

wants to merge 33 commits into from

Conversation

jtjeferreira
Copy link

@jtjeferreira jtjeferreira commented Jan 2, 2025 •
edited
Loading

Building on top your work, I fixed a few of the failing mssql tests reducing the total of failed tests from 85 to 73...

@jtjeferreira jtjeferreira mentioned this pull request Jan 2, 2025
Draft
@kiendang
Copy link
Owner

kiendang commented Jan 3, 2025

Hi @jtjeferreira thanks so much for continuing the work! Could you submit this PR directly to the upstream com-lihaoyi/scalasql repo?

@jtjeferreira
Copy link
Author

Hi @jtjeferreira thanks so much for continuing the work! Could you submit this PR directly to the upstream com-lihaoyi/scalasql repo?

I can, but I didn't want to create another PR, because I am not sure I will be able to get this to the finish line, but I also did not want to "lose" this 4 commits...

@jtjeferreira
fix "Cannot insert explicit value for identity column in table 'buyer…
362b908 
…' when IDENTITY_INSERT is set to OFF"

adds a prequery param to TestChecker so we can call SET IDENTITY_INSERT buyer ON before the query
@kiendang
Copy link
Owner

kiendang commented Jan 3, 2025

I didn't want to create another PR, because I am not sure I will be able to get this to the finish line.

I think it's fine? In case you won't be able to finish it, someone else can still fork your branch and continue from there. I do respect how you want to work though so I'll just leave this PR open so you can push more commits here in the meantime.

@jtjeferreira
Copy link
Author

I will work a bit more here, and then open a PR directly in scalasql. With the recent commits I got it down to 47 failed tests

@jtjeferreira
fix JoinTest except JoinTests.leftJoinExpr
8f27c60
@jtjeferreira
fix ExprNumericOpsTests
8b18a4e
@jtjeferreira
fix SubQueryTests
07fffef
@jtjeferreira
fix DeleteTests and ExprAggOpsTests (except mkString.sep)
a9c0ee4
@jtjeferreira
unrelated: rename DbAggOpsTests.scala to ExprAggOpsTests
cd5863b
@jtjeferreira
a different fix to DeleteTests by improving the where clause in a DEL…
85b9d6c 
…ETE statement
@jtjeferreira
fix TransactionTests (with a TODO)
7b4c31c
@jtjeferreira
ignore ValuesTests for mssql
37b3fe6
@jtjeferreira
add MsSqlEnumType
afac72e
@jtjeferreira
fix DataTypesTests.constant
41ec9d4
@jtjeferreira
fix scalasql.mssql.UpdateTests.dynamic by setting a case-sensitive co…
eebaa8c 
…llation
@jtjeferreira
ignore scalasql.mssql.ExprSeqOpsTests.mkString.sep test
7b9c988
@jtjeferreira
ignore scalasql.mssql.SelectTests.containsMultiple test
19f42f4
@jtjeferreira
simplify JoinTests.leftJoinExpr so it does not use nullsFirst, becaus…
67274df 
…e mssql does not support sorting on aliases
@jtjeferreira
ignore scalasql.mssql.WithCteTests.subquery test
28f5169
@jtjeferreira
fix scalasql.mssql.SchemaTests
3fd8c37
@jtjeferreira
scalafmt
3ce8f13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtjeferreira @kiendang