Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic V&V reporting #3250

Closed
wants to merge 3 commits into from
Closed

add generic V&V reporting #3250

wants to merge 3 commits into from

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented Mar 26, 2020 •
edited
Loading

This was referenced Mar 26, 2020
Closed
Closed
@Rikkola Rikkola changed the title gg add generic V&V reporting Mar 27, 2020
@Rikkola
Copy link
Member Author

Rikkola commented Apr 2, 2020

[ERROR] Internal error: java.lang.RuntimeException: org.eclipse.equinox.p2.core.ProvisionException: Unable to read repository at http://download.jboss.org/jbosstools/updates/requirements/m2eclipse-tycho/0.8.1.201704211436/artifacts.jar. connect timed out -> [Help 1]

Jenkins please restest

Rikkola
Rikkola commented Apr 7, 2020
View reviewed changes
kie-wb-common-dmn/kie-wb-common-dmn-webapp-standalone/pom.xml Outdated
@@ -914,6 +929,8 @@
<compileSourcesArtifact>org.kie.workbench.services:kie-wb-common-datamodel-api</compileSourcesArtifact>
<compileSourcesArtifact>org.kie.workbench.services:kie-wb-common-services-api</compileSourcesArtifact>
<compileSourcesArtifact>org.kie.workbench:kie-wb-common-kogito-client</compileSourcesArtifact>
<!-- <compileSourcesArtifact>org.drools:drools-verifier-api</compileSourcesArtifact>-->
<!-- <compileSourcesArtifact>org.drools:drools-verifier-core</compileSourcesArtifact>-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rush and remove this commented code!

@jomarko jomarko self-requested a review April 8, 2020 05:57
@manstis manstis self-requested a review April 8, 2020 08:47
@manstis
Copy link
Member

manstis commented Apr 8, 2020

null error

  • Add InputData
  • Set data-type to string
  • Add Decision
  • Set expression to Decision Table
  • Do nothing else
  • Validate

Screenshot from 2020-04-08 10-29-07

Index error

  • Add InputData
  • Set data-type to string
  • Add Decision
  • Set expression to Decision Table
  • Set output column datatype to number
  • Set output value cell to a number
  • Validate

Screenshot from 2020-04-08 10-27-47

@jomarko
Copy link

jomarko commented Apr 8, 2020

@Rikkola I will postpone until you have look on @manstis comments, seems quite blocking

@Rikkola Rikkola marked this pull request as ready for review April 8, 2020 10:34
@Rikkola
Copy link
Member Author

Rikkola commented Apr 8, 2020

@manstis @jomarko it looks like this issue was already there. I'll make ticket.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manstis
Copy link
Member

manstis commented Apr 8, 2020

@Rikkola OK, I can confirm the null case exists with master

Screenshot from 2020-04-08 15-46-42

However the second case (where this PR shows a message relating to "index") is better reported by master. Can the message produced by this PR be consistent with master so Users have some idea what is going on?

Screenshot from 2020-04-08 15-46-55

@manstis
Copy link
Member

manstis commented Apr 8, 2020

@Rikkola I tried the following simple case in both master and this PR.

Subsumption correctly reported by master

Screenshot from 2020-04-08 15-49-17

Index error reported by this PR

Screenshot from 2020-04-08 15-58-56

@manstis
Copy link
Member

manstis commented Apr 8, 2020 •
edited
Loading

@Rikkola Can I please also ask, to aid testing, can you provide a table showing the different checks and where each is implemented for example:

Check old kie-dmn new drools-vv
Impossible range x
Subsumption x
Gap analysis x

etc

An example of each would be good too, so we can verify new is working the same as old.

@Rikkola Rikkola marked this pull request as draft July 1, 2020 07:04
@Rikkola Rikkola closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomarko jomarko Awaiting requested review from jomarko

@manstis manstis Awaiting requested review from manstis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rikkola @manstis @jomarko