DROOLS-1663 Kie DMN doesn't support IMPORT decisions between DMN files #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etirelli
approved these changes
Mar 24, 2018
winklerm
suggested changes
Mar 25, 2018
|
|
||
| Resource getResource(); | ||
|
|
||
| ResourceConfiguration getResourceConfigutation(); |
There was a problem hiding this comment.
Please fix the typo in getResourceConfigutation.
| ResourceConfiguration getResourceConfigutation(); | ||
|
|
||
| /** | ||
| * callback executed on `kbuilder` as a paramenter in {@link KieAssemblerService}, which will be executed before performing {@link KieAssemblerService#addResource(Object, Resource, ResourceType, ResourceConfiguration)} for the given resource {@link #getResource()}. |
|
|
||
| public interface KieAssemblerService extends KieService { | ||
| ResourceType getResourceType(); | ||
|
|
||
| default void addResources(Object kbuilder, Collection<ResourceWithConfiguration> resources, ResourceType type) throws Exception { |
There was a problem hiding this comment.
I assume there is no suitable interface/class that could be used here instead of Object?
There was a problem hiding this comment.
@winklerm correct, and this is for consistency with the other method in class KieAssemblerService
|
/cc @mariofusco as impacting on public API |
mariofusco
approved these changes
Mar 26, 2018
|
looks good to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.