combine start/enable service in one line #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's more concise
c0495f5 to
b69fb58
Compare
|
cleaner PR |
eliecharra
requested changes
Mar 14, 2017
| name: traefik | ||
| state: started | ||
| - name: Ensure traefik service is enabled and running | ||
| service: name=traefik state=started enabled=yes |
There was a problem hiding this comment.
@sjourdan Could you remove task inline config (name=...) and put each option on a single line to be ?
To be more homogenous with the rest of the role.
|
I merge this, will fix style in master |
eliecharra
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.