Skip to content

Commit

Permalink
SKA: Fix kebab-case issues in obs-ux-management packages (elastic#211312
Browse files Browse the repository at this point in the history
)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 4 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/alerting-rule-utils` |
`x-pack/platform/packages/shared/alerting-rule-utils` |
| `@kbn/observability-alert-details` |
`x-pack/solutions/observability/packages/alert-details` |
| `@kbn/observability-alerting-test-data` |
`x-pack/solutions/observability/packages/alerting-test-data` |
| `@kbn/observability-get-padded-alert-time-range-util` |
`x-pack/solutions/observability/packages/get-padded-alert-time-range-util`
|

<details >
<summary>Updated references</summary>

```
./.i18nrc.json
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/platform/packages/shared/alerting-rule-utils/jest.config.js
./x-pack/solutions/observability/packages/alert-details/jest.config.js
./x-pack/solutions/observability/packages/alerting-test-data/jest.config.js
./x-pack/solutions/observability/packages/get-padded-alert-time-range-util/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/platform/packages/shared/alerting-rule-utils/jest.config.js:10
x-pack/platform/packages/shared/alerting-rule-utils/tsconfig.json:2
x-pack/solutions/observability/packages/alert-details/jest.config.js:10
x-pack/solutions/observability/packages/alert-details/tsconfig.json:2
x-pack/solutions/observability/packages/alerting-test-data/jest.config.js:10
x-pack/solutions/observability/packages/alerting-test-data/tsconfig.json:2
x-pack/solutions/observability/packages/get-padded-alert-time-range-util/jest.config.js:10
x-pack/solutions/observability/packages/get-padded-alert-time-range-util/tsconfig.json:2
```

</details>

(cherry picked from commit 171dd6b)
  • Loading branch information
gsoldevila committed Feb 17, 2025
1 parent 5292b3f commit 36c84fc
Show file tree
Hide file tree
Showing 55 changed files with 25 additions and 25 deletions.
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ x-pack/platform/packages/shared/ai-assistant/common @elastic/search-kibana
x-pack/platform/packages/shared/ai-assistant/icon @elastic/appex-sharedux
x-pack/platform/packages/shared/ai-infra/inference-common @elastic/appex-ai-infra
x-pack/platform/packages/shared/ai-infra/product-doc-common @elastic/appex-ai-infra
x-pack/platform/packages/shared/alerting_rule_utils @elastic/obs-ux-management-team
x-pack/platform/packages/shared/alerting-rule-utils @elastic/obs-ux-management-team
x-pack/platform/packages/shared/file-upload-common @elastic/ml-ui
x-pack/platform/packages/shared/index-lifecycle-management/index_lifecycle_management_common_shared @elastic/kibana-management
x-pack/platform/packages/shared/index-management/index_management_shared_types @elastic/kibana-management
Expand Down Expand Up @@ -913,9 +913,9 @@ x-pack/platform/plugins/shared/stack_connectors @elastic/response-ops
x-pack/platform/plugins/shared/task_manager @elastic/response-ops
x-pack/platform/plugins/shared/timelines @elastic/security-threat-hunting-investigations
x-pack/platform/plugins/shared/triggers_actions_ui @elastic/response-ops
x-pack/solutions/observability/packages/alert_details @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/alerting_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/get_padded_alert_time_range_util @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/alert-details @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/alerting-test-data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/get-padded-alert-time-range-util @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/kbn-alerts-grouping @elastic/response-ops
x-pack/solutions/observability/packages/kbn-custom-integrations @elastic/obs-ux-logs-team
x-pack/solutions/observability/packages/kbn-investigation-shared @elastic/obs-ux-management-team
Expand Down
2 changes: 1 addition & 1 deletion .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"domDragDrop": "src/platform/packages/shared/kbn-dom-drag-drop",
"controls": "src/platform/plugins/shared/controls",
"data": "src/platform/plugins/shared/data",
"observabilityAlertDetails": "x-pack/solutions/observability/packages/alert_details",
"observabilityAlertDetails": "x-pack/solutions/observability/packages/alert-details",
"dataViews": "src/platform/plugins/shared/data_views",
"defaultNavigation": ["packages/default-nav", "src/platform/packages/private/default-nav"],
"devTools": "src/platform/plugins/shared/dev_tools",
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
"@kbn/alerting-example-plugin": "link:x-pack/examples/alerting_example",
"@kbn/alerting-fixture-plugin": "link:x-pack/test/functional_with_es_ssl/plugins/alerts",
"@kbn/alerting-plugin": "link:x-pack/platform/plugins/shared/alerting",
"@kbn/alerting-rule-utils": "link:x-pack/platform/packages/shared/alerting_rule_utils",
"@kbn/alerting-rule-utils": "link:x-pack/platform/packages/shared/alerting-rule-utils",
"@kbn/alerting-state-types": "link:x-pack/platform/packages/private/kbn-alerting-state-types",
"@kbn/alerting-types": "link:src/platform/packages/shared/kbn-alerting-types",
"@kbn/alerts-as-data-utils": "link:src/platform/packages/shared/kbn-alerts-as-data-utils",
Expand Down Expand Up @@ -701,10 +701,10 @@
"@kbn/observability-ai-assistant-plugin": "link:x-pack/platform/plugins/shared/observability_ai_assistant",
"@kbn/observability-ai-common": "link:x-pack/solutions/observability/packages/observability-ai/observability-ai-common",
"@kbn/observability-ai-server": "link:x-pack/solutions/observability/packages/observability-ai/observability-ai-server",
"@kbn/observability-alert-details": "link:x-pack/solutions/observability/packages/alert_details",
"@kbn/observability-alerting-test-data": "link:x-pack/solutions/observability/packages/alerting_test_data",
"@kbn/observability-alert-details": "link:x-pack/solutions/observability/packages/alert-details",
"@kbn/observability-alerting-test-data": "link:x-pack/solutions/observability/packages/alerting-test-data",
"@kbn/observability-fixtures-plugin": "link:x-pack/test/cases_api_integration/common/plugins/observability",
"@kbn/observability-get-padded-alert-time-range-util": "link:x-pack/solutions/observability/packages/get_padded_alert_time_range_util",
"@kbn/observability-get-padded-alert-time-range-util": "link:x-pack/solutions/observability/packages/get-padded-alert-time-range-util",
"@kbn/observability-logs-explorer-plugin": "link:x-pack/solutions/observability/plugins/observability_logs_explorer",
"@kbn/observability-onboarding-plugin": "link:x-pack/solutions/observability/plugins/observability_onboarding",
"@kbn/observability-plugin": "link:x-pack/solutions/observability/plugins/observability",
Expand Down
16 changes: 8 additions & 8 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
"@kbn/alerting-fixture-plugin/*": ["x-pack/test/functional_with_es_ssl/plugins/alerts/*"],
"@kbn/alerting-plugin": ["x-pack/platform/plugins/shared/alerting"],
"@kbn/alerting-plugin/*": ["x-pack/platform/plugins/shared/alerting/*"],
"@kbn/alerting-rule-utils": ["x-pack/platform/packages/shared/alerting_rule_utils"],
"@kbn/alerting-rule-utils/*": ["x-pack/platform/packages/shared/alerting_rule_utils/*"],
"@kbn/alerting-rule-utils": ["x-pack/platform/packages/shared/alerting-rule-utils"],
"@kbn/alerting-rule-utils/*": ["x-pack/platform/packages/shared/alerting-rule-utils/*"],
"@kbn/alerting-state-types": ["x-pack/platform/packages/private/kbn-alerting-state-types"],
"@kbn/alerting-state-types/*": ["x-pack/platform/packages/private/kbn-alerting-state-types/*"],
"@kbn/alerting-types": ["src/platform/packages/shared/kbn-alerting-types"],
Expand Down Expand Up @@ -1344,14 +1344,14 @@
"@kbn/observability-ai-common/*": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-common/*"],
"@kbn/observability-ai-server": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-server"],
"@kbn/observability-ai-server/*": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-server/*"],
"@kbn/observability-alert-details": ["x-pack/solutions/observability/packages/alert_details"],
"@kbn/observability-alert-details/*": ["x-pack/solutions/observability/packages/alert_details/*"],
"@kbn/observability-alerting-test-data": ["x-pack/solutions/observability/packages/alerting_test_data"],
"@kbn/observability-alerting-test-data/*": ["x-pack/solutions/observability/packages/alerting_test_data/*"],
"@kbn/observability-alert-details": ["x-pack/solutions/observability/packages/alert-details"],
"@kbn/observability-alert-details/*": ["x-pack/solutions/observability/packages/alert-details/*"],
"@kbn/observability-alerting-test-data": ["x-pack/solutions/observability/packages/alerting-test-data"],
"@kbn/observability-alerting-test-data/*": ["x-pack/solutions/observability/packages/alerting-test-data/*"],
"@kbn/observability-fixtures-plugin": ["x-pack/test/cases_api_integration/common/plugins/observability"],
"@kbn/observability-fixtures-plugin/*": ["x-pack/test/cases_api_integration/common/plugins/observability/*"],
"@kbn/observability-get-padded-alert-time-range-util": ["x-pack/solutions/observability/packages/get_padded_alert_time_range_util"],
"@kbn/observability-get-padded-alert-time-range-util/*": ["x-pack/solutions/observability/packages/get_padded_alert_time_range_util/*"],
"@kbn/observability-get-padded-alert-time-range-util": ["x-pack/solutions/observability/packages/get-padded-alert-time-range-util"],
"@kbn/observability-get-padded-alert-time-range-util/*": ["x-pack/solutions/observability/packages/get-padded-alert-time-range-util/*"],
"@kbn/observability-logs-explorer-plugin": ["x-pack/solutions/observability/plugins/observability_logs_explorer"],
"@kbn/observability-logs-explorer-plugin/*": ["x-pack/solutions/observability/plugins/observability_logs_explorer/*"],
"@kbn/observability-onboarding-plugin": ["x-pack/solutions/observability/plugins/observability_onboarding"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/platform/packages/shared/alerting_rule_utils'],
roots: ['<rootDir>/x-pack/platform/packages/shared/alerting-rule-utils'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/alert_details'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/alert-details'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/alerting_test_data'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/alerting-test-data'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/get_padded_alert_time_range_util'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/get-padded-alert-time-range-util'],
};
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3965,7 +3965,7 @@
version "0.0.0"
uid ""

"@kbn/alerting-rule-utils@link:x-pack/platform/packages/shared/alerting_rule_utils":
"@kbn/alerting-rule-utils@link:x-pack/platform/packages/shared/alerting-rule-utils":
version "0.0.0"
uid ""

Expand Down Expand Up @@ -6557,19 +6557,19 @@
version "0.0.0"
uid ""

"@kbn/observability-alert-details@link:x-pack/solutions/observability/packages/alert_details":
"@kbn/observability-alert-details@link:x-pack/solutions/observability/packages/alert-details":
version "0.0.0"
uid ""

"@kbn/observability-alerting-test-data@link:x-pack/solutions/observability/packages/alerting_test_data":
"@kbn/observability-alerting-test-data@link:x-pack/solutions/observability/packages/alerting-test-data":
version "0.0.0"
uid ""

"@kbn/observability-fixtures-plugin@link:x-pack/test/cases_api_integration/common/plugins/observability":
version "0.0.0"
uid ""

"@kbn/observability-get-padded-alert-time-range-util@link:x-pack/solutions/observability/packages/get_padded_alert_time_range_util":
"@kbn/observability-get-padded-alert-time-range-util@link:x-pack/solutions/observability/packages/get-padded-alert-time-range-util":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 36c84fc

Please sign in to comment.