Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prop 'clearButtonEnabled' #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jomla97
Copy link

@jomla97 jomla97 commented Feb 15, 2018

This prop allows the component to be used without the clearButton. With 'clearButtonEnabled' set to true, none of the other clearButton props will be used (since the clearButton will not be rendered).

@khaiql
Copy link
Owner

khaiql commented Feb 20, 2018

Why do you have to check for the prop? There is no definition for showClearButton in https://github.com/jomla97/react-native-progressive-input/blob/507fc2a0ca923939dc4700f965feacacb0ee3abc/index.js#L13

@jomla97 jomla97 changed the title Added prop 'showClearButton' Added prop 'clearButtonEnabled' Feb 20, 2018
@jomla97
Copy link
Author

jomla97 commented Feb 20, 2018

Sorry, I was in a bit of a rush because I needed the component without the clearButton.. I changed the prop name to something a little more logical that fits in with the rest of the clearButton props. Also added the PropTypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants