[WIP] Upgrade Admin UI to Apollo Client 3 #3279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
jordanoverbye
commented
Jul 23, 2020
| @@ -35,7 +35,7 @@ | |||
| "@keystonejs/oembed-adapters": "^5.1.4", | |||
| "apollo-cache-inmemory": "^1.6.6", | |||
| "apollo-client": "^2.6.10", | |||
| "apollo-upload-client": "^13.0.0", | |||
| "apollo-upload-client": "^14.1.0", | |||
There was a problem hiding this comment.
Upgrading these versions of apollo-upload-client so that all versions in the monorepo are the same
jordanoverbye
commented
Jul 23, 2020
|
|
||
| import fetch from 'cross-fetch'; | ||
|
|
||
| // This shouldn't be necessary, but it silences an annoying error from Apollo | ||
| // Client: https://github.com/apollographql/apollo-client/issues/3397#issuecomment-421433032 | ||
| const fragmentMatcher = new IntrospectionFragmentMatcher({ |
There was a problem hiding this comment.
The IntrospectionFragmentMatcher has been removed in Apollo Client v3. See here apollographql/apollo-client#5073
|
I already have this done in #3125. Just needed to get one test working. |
|
Didn't see that @Vultraz. Going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.