Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): dist path for server 🎢 #6860

Merged

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jun 28, 2022

Fixes #6859.

Addresses the test blocks encountered in #6848, #6849. Note that I have now rebased those two PRs off this PR chain, so that they can be tested and merged independently. It turns out that this fix is needed for those PRs, because this broke with the removal of Lerna in #6525 (we postponed regression testing of Developer on that PR because we knew we needed to do it anyway). So I am going to do some more rebasing so we can get these all tested.

The production path needed to have all files under the build/dist/ folder, not just the build/ folder. This was broken in the refactor in #6630.

User Testing

This 🎢 reorganisation chain impacts Windows and Developer. This means we need to run regression tests on the impacted products. I do not anticipate serious issues but there is potential for errors that are not picked up in the build process.

  • TEST_WINDOWS: Please run a full regression test on Keyman for Windows.
  • TEST_DEVELOPER: Please run a full regression test on Keyman Developer.

I have verified that this fixes the test block encountered in #6848.

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner June 28, 2022 01:07
@mcdurdin mcdurdin added this to the A16S5 milestone Jun 28, 2022
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jun 28, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jun 28, 2022

User Test Results

Test specification and instructions

Test Artifacts

Fixes #6859.

The production path needed to have all files under the build/dist/
folder, not just the build/ folder. Broken in the refactor in #6630.
@mcdurdin
Copy link
Member Author

mcdurdin commented Jul 4, 2022

Test Results

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jul 5, 2022
@mcdurdin mcdurdin merged commit f2d8fd0 into chore/developer/js-to-lmc Jul 5, 2022
@mcdurdin mcdurdin deleted the fix/developer/dist-path-for-server branch July 5, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): invalid 'main' field when starting Developer Server
2 participants