-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): fixup languageProcessor text unit tests 🎡 #6622
Merged
mcdurdin
merged 4 commits into
chore/web/no-more-lerna
from
chore/web/fixup-predictive-text-unit-tests
May 26, 2022
Merged
chore(web): fixup languageProcessor text unit tests 🎡 #6622
mcdurdin
merged 4 commits into
chore/web/no-more-lerna
from
chore/web/fixup-predictive-text-unit-tests
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses "Poor Man's Modules" until we have ES6, just so we can get passing tests.
User Test ResultsTest specification and instructions User tests are not required |
15 tasks
This is probably not needed at the bundling stage.
darcywong00
reviewed
May 17, 2022
jahorton
pushed a commit
that referenced
this pull request
May 18, 2022
jahorton
pushed a commit
that referenced
this pull request
May 23, 2022
jahorton
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As #6632 will resolve the "poor man's modules" approach (temporarily used here) in the near future, I'm fine giving this the go-ahead for now.
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
Base automatically changed from
chore/remove-package-locks
to
chore/web/no-more-lerna
May 26, 2022 22:52
…e-text-unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses "Poor Man's Modules" until we have ES6, just so we can get passing
tests.
@keymanapp-test-bot skip