Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fixup languageProcessor text unit tests 🎡 #6622

Merged

Conversation

mcdurdin
Copy link
Member

Uses "Poor Man's Modules" until we have ES6, just so we can get passing
tests.

@keymanapp-test-bot skip

Uses "Poor Man's Modules" until we have ES6, just so we can get passing
tests.
@mcdurdin mcdurdin added this to the A16S2 milestone May 16, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 16, 2022

User Test Results

Test specification and instructions

User tests are not required

This is probably not needed at the bundling stage.
Copy link
Contributor

@jahorton jahorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #6632 will resolve the "poor man's modules" approach (temporarily used here) in the near future, I'm fine giving this the go-ahead for now.

Co-authored-by: Darcy Wong <darcy_wong@sil.org>
Base automatically changed from chore/remove-package-locks to chore/web/no-more-lerna May 26, 2022 22:52
@mcdurdin mcdurdin merged commit b58b546 into chore/web/no-more-lerna May 26, 2022
@mcdurdin mcdurdin deleted the chore/web/fixup-predictive-text-unit-tests branch May 26, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants