Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install googletest via make setup #1084

Closed
wants to merge 1 commit into from
Closed

Install googletest via make setup #1084

wants to merge 1 commit into from

Conversation

The-Compiler
Copy link
Contributor

Would make it easier to update in the future. Alternative to #1083, fixes #1081.

Would make it easier to update in the future. Alternative to #1083, fixes #1081.

Signed-off-by: Florian Bruhin <me@the-compiler.org>
@obra
Copy link
Member

obra commented Sep 3, 2021

I'm going to close this one out in favor of #1083 - In general, I'm a fan of snapshotting deps, having been burned repeatedly by third-party dependency repositories changing out from under me, breaking code that "used to work"

@obra obra closed this Sep 3, 2021
@obra obra reopened this Sep 3, 2021
@obra obra closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bundled gtest to 1.11.0 to avoid fatal maybe-uninitialized error with GCC 11
2 participants