-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show social proofs in search results #1234
Conversation
<Image style={styles.serviceIcon} source={serviceIcons[proof.get('proofType')]}/> | ||
{proof === matchingProof ? <Text | ||
style={styles.serviceName} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaner like this?
proof === matchingProof
&& (
<Text>
...
</Text>
)
LG%C |
@@ -0,0 +1,21 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I know I told you to do this but just FYI to all @keybase/react-hackers there changing how assets work in the next version: facebook/react-native#3545
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
👍 % comments |
44564be
to
58ea292
Compare
Would someone with Android verify that this works? I can't get the app running in the emulator at the moment. |
I wonder if the Appveyor thing would help |
(oh, Appveyor is the Windows build.. I was thinking of the one that lets you run the Android app remotely.) |
Appetizer I think On Wednesday, October 28, 2015, Chris Ball notifications@github.com wrote:
|
I haven't heard anything back in a few days, so I'm mergin'. |
Show social proofs in search results
r? @chrisnojima @MarcoPolo