[IDEA] Defining surface plugin for IDEA muon-system + modifying the hierarchy of the detElement to cope with surfaces

[mahmoudali2]

BEGINRELEASENOTES

• Adding general surface plugin for IDEA muon-system.
• Fixing of the hierarchy of the detElemnt (the former one had errors when running with surfaces).
• Now we have ~ 7256 surfaces, but 'ddPlanarDigi' still complaining that it doesn't see surfaces!

ENDRELEASENOTES

[atolosadelgado]

Hi @mahmoudali2

Thanks for this PR!

Could you please address the CI test that is failing? link

This is the error message:

IDDescriptor     ERROR dd4hep: PreshowerSystemCollection: This ID descriptor has no field with the name: side
DD4hep_VolumeManager ERROR Exception: IDDescriptor: dd4hep: PreshowerSystemCollection: This ID descriptor has no field with the name: side
     dd4hep: while programming VolumeManager. Are your volIDs correct?

[mahmoudali2]

Sorry @atolosadelgado I forgot to adopt pre-shower with the updates on the builder, but now it's done.. I updates the pre-shower xml too.

[atolosadelgado]

Hi @mahmoudali2

thanks! The code seems reasonable to me. Do you think it is worth to update the readme with your changes? link

[mahmoudali2]

Done. @atolosadelgado