Evtgenfix #35
Evtgenfix #35
Conversation
|
need to clean this PR, did not paid attention pythia stuff where also pushed |
|
Done with cleaning |
|
There should ideally be a test for the issue you mention, but that'll take some time, so I created an issue to do this at a future date. Could you still rebase and remove the whitespace changes? |
| {"ScalarHT"}); | ||
| {""}); |
There was a problem hiding this comment.
I'm not sure you need to change the converter, maybe by accident?
There was a problem hiding this comment.
this was a local change indeed that I reverted. If we don't remove the hardcoded names in the converter, there is not the possibility to not save a collection by removing it from the output_config.tcl
There was a problem hiding this comment.
I think these are fixing a different kind of "problem". Without these changes, the converter will always fill these collections, even if you remove them from your output config file. I.e. the defaults here might override your configuration. Without these fixes you have to explicitly touch the delphes card and remove the branches you do not want from the TreeWriter config section. With these changes you can leave the delphes card untouched and simply suppress these outputs by removing them from the output configuration.
There was a problem hiding this comment.
BTW @tmadlener , using the default configuration for the output I do not see ScalarHT in the output root files.
I never noticed it because I am not using it until now while I was testing the collection removal
There was a problem hiding this comment.
That might be because ScalarHT is not in the TreeWriter configuration? By default the converter will only try to convert what is actually there.
|
thanks @vvolkl , I also made the verbose flag to false. |
|
is there anything before we merge this? |
* Fixes a bug with charge conjugate decays in EvtGen * Found by @clementhelsens and fixed by @mchrzasz Co-authored-by: Clement Helsens <clement.helsens@cern.ch>
|
It cannot be rebased, but I'll merge this changes in #40 |
* Fixes a bug with charge conjugate decays in EvtGen * Found by @clementhelsens and fixed by @mchrzasz Co-authored-by: Clement Helsens <clement.helsens@cern.ch>
BEGINRELEASENOTES
ENDRELEASENOTES