Overhaul python configuration of EDM conversion tools #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolkl
reviewed
Nov 7, 2022
d88c585 to
8612260
Compare
tmadlener
commented
Nov 7, 2022
0b81b4f to
8a1acf8
Compare
andresailer
reviewed
Nov 7, 2022
andresailer
reviewed
Nov 8, 2022
Make it possible to convert everything but still change mapped names
69324dd to
2bf17a5
Compare
|
Copy & paste has its downsides ;) Thanks for checking. Hope I got everything now. |
|
@andresailer letting you approve here (then auto-merge should kick in I think) |
andresailer
approved these changes
Nov 15, 2022
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
convertAllflag and acollNameMapping(map of string to string). This makes it possible to more easily convert all collections, but still override the naming of the target collection without having to type out all possible collections.ENDRELEASENOTES
The main reason for implementing this is that it would allow for a rather easy solution of AIDASoft/DD4hep#921, because consistency between existing Marlin processors and ddsim with EDM4hep output could be established on the fly during the conversion (without having to know up front which collections will be there).
Fixes AIDASoft/DD4hep#921