Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options file for CED event display via wrapper #85

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Add a gaudi options file that can be used to run the event display using the CLIC detector via the Marlin wrapper.

ENDRELEASENOTES

@fdplacido I am not entirely sure where to best put this. Having such a large file purely in the documentation as an inline code block seems a bit excessive to me. If we had it somewhere in the repository, I could link from the documentation to the complete file and focus the documentation on the essential parts. What do you think? Also if there is a better suited place for this let me know.

@fdplacido
Copy link
Contributor

I think the file is fine here. The documentation file should just link to it, maybe inlining some relevant lines.

@fdplacido fdplacido merged commit 869ddf4 into key4hep:master Jun 27, 2022
@vvolkl
Copy link
Contributor

vvolkl commented Jun 27, 2022

Alternatively, add a #!k4run shebang and install to bin.

@tmadlener
Copy link
Contributor Author

Alternatively, add a #!k4run shebang and install to bin.

Ah good idea. Using #!/usr/bin/env k4run would make it work without having to install it to bin. Will do that in the documentation PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants