Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert RecoParticleVertexAssociation and MCRecoTrackParticleAssociation #62

Merged
merged 1 commit into from
Mar 2, 2022
Merged

convert RecoParticleVertexAssociation and MCRecoTrackParticleAssociation #62

merged 1 commit into from
Mar 2, 2022

Conversation

vvolkl
Copy link
Contributor

@vvolkl vvolkl commented Dec 14, 2021

BEGINRELEASENOTES

  • convert RecoParticleVertexAssociation and MCRecoTrackParticleAssociation

ENDRELEASENOTES

@vvolkl vvolkl requested a review from fdplacido December 14, 2021 17:00
fdplacido
fdplacido suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@fdplacido fdplacido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs clang-format applied, else looks good.

@vvolkl
Copy link
Contributor Author

vvolkl commented Dec 15, 2021

Build failure with release expected; needs key4hep/EDM4hep#133

@fdplacido fdplacido added the needs external PR It needs merged changes from external repositories label Dec 15, 2021
@andresailer
Copy link
Collaborator

Please squash the commits

@fdplacido fdplacido removed the needs external PR It needs merged changes from external repositories label Jan 14, 2022
@fdplacido fdplacido merged commit 5708a93 into key4hep:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdplacido fdplacido fdplacido requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvolkl @andresailer @fdplacido