Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to convert all collections #61

Merged
merged 6 commits into from
Dec 15, 2021

Conversation

fdplacido
Copy link
Contributor

@fdplacido fdplacido commented Dec 9, 2021

BEGINRELEASENOTES

  • LCIO -> EDM4hep, and EDM4hep -> LCIO converters now have the option to convert all available collections
  • Updated docs

Needs:

ENDRELEASENOTES

@fdplacido fdplacido requested a review from andresailer December 9, 2021 11:09
@fdplacido fdplacido added enhancement New feature or request needs external PR It needs merged changes from external repositories labels Dec 9, 2021
@andresailer
Copy link
Collaborator

Please fix the faulty logic in the Tests CmakeLists to make the test with conversion run

if(${k4lcioreader_PATH} MATCHES "/sw-nightly.hsf.org/")
MESSAGE(FATAL_ERROR "we must be here ${k4lcioreader_PATH}")

(fix the path to sw-nightlies , drop the FATAL_ERROR)

@fdplacido
Copy link
Contributor Author

Fixed. Note the tests won't pass anyway until the referenced PRs are merged.

@vvolkl vvolkl merged commit 2974008 into key4hep:master Dec 15, 2021
@fdplacido fdplacido deleted the convert_all_collections_option branch January 19, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs external PR It needs merged changes from external repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants