-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequence stop on not finding more events to process #42
Add sequence stop on not finding more events to process #42
Conversation
Fixes #36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fdplacido,
Thanks for taking care of this. Looks good to me.
I have two minor questions that only concern the tests: Wouldn't it be possible to run the tests via k4run [...] --num-events=[number of events]
? In that way only one options file and bash script would be necessary to cover both currently present tests. Also I think it would be nice to add a comparison of the number of events in the input file and the output file via lcio_event_counter
(just to be really sure that there is no empty event).
I changed it to use |
I added a test to check that using |
I updated as you suggested, checking now for correct number of output events with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
cc960a0
to
9299082
Compare
BEGINRELEASENOTES
ENDRELEASENOTES