Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converter script changes #21

Merged
merged 22 commits into from
Nov 6, 2020
Merged

Converter script changes #21

merged 22 commits into from
Nov 6, 2020

Conversation

fdplacido
Copy link
Contributor

@fdplacido fdplacido commented Oct 30, 2020 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • steeringFileConverter

    • Add constants parsing of XML files
    • Add test case for multiple constants, lists and nested constants replacing

  • Removed BOOST dependency

ENDRELEASENOTES

@fdplacido fdplacido requested a review from andresailer October 30, 2020 11:01
@fdplacido fdplacido changed the title Plfernan converter script changes Converter script changes Oct 30, 2020
@andresailer andresailer linked an issue Nov 2, 2020 that may be closed by this pull request
constant value replacement and include loading is not done during conversion of xml steering files #18
Closed
andresailer
andresailer requested changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
A bit of cleanup and documentation for the python parts are still needed.

@fdplacido fdplacido requested a review from andresailer November 6, 2020 08:57
@andresailer andresailer merged commit d695cf4 into key4hep:master Nov 6, 2020
@fdplacido fdplacido deleted the plfernan_converter_script_changes branch June 17, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

constant value replacement and include loading is not done during conversion of xml steering files
2 participants
@fdplacido @andresailer