Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing calohit contributions if all SimCalo hit collections are empty #157

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix missing calohit contributions if all SimCalo hit collections are empty #157

merged 2 commits into from
Nov 2, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Nov 2, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Make sure to always create a CaloHitContribution collection if any SimCalorimeterHit is seen in the conversion even if all of them are empty.
  • Use the global object map to resolve MCParticle relations for these contributions.

ENDRELEASENOTES

Fixes key4hep/k4FWCore#156

@Zehvogel Zehvogel mentioned this pull request Nov 2, 2023
Closed
@Zehvogel
Copy link
Contributor

Zehvogel commented Nov 2, 2023

fixes key4hep/k4FWCore#156 for me. Thx!

@tmadlener
Copy link
Contributor Author

Thanks for testing.

@tmadlener tmadlener changed the title [WIP] Fix missing calohit contributions Fix missing calohit contributions if all SimCalo hit collections are empty Nov 2, 2023
@tmadlener tmadlener merged commit 17981e9 into key4hep:main Nov 2, 2023
@tmadlener tmadlener deleted the fix-missing-calohit-contrib branch November 2, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird segfaults in PodioOutput
2 participants
@tmadlener @Zehvogel