Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the examples to the correct place for key4hep-stack installations #100

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Dec 7, 2022

BEGINRELEASENOTES

  • Examples and other shared resources should go to <prefix>/share/k4MarlinWrapper in order for key4hep-stack environment variables to be properly populated. This fixes a problem where $K4MARLINWRAPPER points to an empty directory.
  • Make sure to run the doctest workflows using the newly built version of k4MarlinWrapper
  • Add CEDViaWrapper to the things that are run in the doctest workflow.
  • Update github actions versions in CI.

ENDRELEASENOTES

  • The CEDViewer via wrapper example is not currently run in the doctest workflow, otherwise we should have realized this much earlier. I am not yet entirely sure if we can run that in a non-interactive shell though.
    • Check if the example can be run

@ebrondol
Copy link
Contributor

ebrondol commented Dec 7, 2022

Thanks Thomas for the prompt fix.

@tmadlener tmadlener force-pushed the install-correct-share branch from 3313b79 to 86ee93a Compare December 7, 2022 14:29
@tmadlener tmadlener force-pushed the install-correct-share branch from 86ee93a to 2addb50 Compare December 8, 2022 12:57
@andresailer andresailer merged commit 51dc49f into key4hep:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants