Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running over more events than present or all events (using -1) should exit with 0 #125

Closed
tmadlener opened this issue Jul 20, 2023 · 0 comments · Fixed by #132
Closed

Running over more events than present or all events (using -1) should exit with 0 #125

tmadlener opened this issue Jul 20, 2023 · 0 comments · Fixed by #132
Assignees
@Zehvogel
Labels
enhancement New feature or request

Comments

@tmadlener
Copy link
Contributor

tmadlener commented Jul 20, 2023 •
edited
Loading

Currently anything that makes Gaudi use a IEventProcessor::stopRun makes the whole process exit with exit code 4 (see here).

This requires us to do things like this in tests:

k4FWCore/test/k4FWCoreTest/CMakeLists.txt

Lines 60 to 62 in 33ba587

set_tests_properties( CheckExampleEventData
PROPERTIES PASS_REGULAR_EXPRESSION "Application Manager Terminated successfully with a user requested ScheduledStop"
DEPENDS CreateExampleEventData)

It also makes it impossible to defensively script (using -e). This should be fixed somehow, although I do not know how.
@tmadlener tmadlener added the enhancement New feature or request label Jul 20, 2023
This was referenced Jul 20, 2023
Merged
Closed
Merged
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 2, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
daf4340 
… `-1`) should exit with 0 key4hep#125
@Zehvogel Zehvogel mentioned this issue Aug 2, 2023
Merged
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 3, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
c78d853 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 3, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
cb8a2fa 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 11, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
4ad6680 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 22, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
c7f5354 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 22, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
1fb0734 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Aug 23, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
cc79b27 
… `-1`) should exit with 0 key4hep#125
Zehvogel added a commit to Zehvogel/k4FWCore that referenced this issue Sep 1, 2023
@Zehvogel
k4run: fix Running over more events than present or all events (using…
7e632bc 
… `-1`) should exit with 0 key4hep#125
@tmadlener tmadlener mentioned this issue Sep 13, 2023
Merged
@dudarboh dudarboh mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zehvogel Zehvogel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

k4run: return exit code 0 if -n -1 was used and Gaudi returned exit code 4 Zehvogel/k4FWCore
2 participants
@Zehvogel @tmadlener