-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the functionality of converting parameters #102
Conversation
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.ipp
Outdated
Show resolved
Hide resolved
0338e12
to
a4c7987
Compare
so that a Frame may be passed or not
a4c7987
to
3fcae7f
Compare
I have added a second template parameter to this and introduced the edit: Also I have put the original overload back for convenience since it's effectively a one line wrapper. |
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h
Outdated
Show resolved
Hide resolved
Makes it possible to remove the dependency on k4FWCore
c65086f
to
2db7e16
Compare
This reverts commit 9a0ae14.
so that a Frame may be passed or not. This is needed to use IOSvc with the Marlin wrapper, because in that case there is not a frame that is passed around like with the
PodioDataSvc
.convertObjectParameters
take a function object as argument that deals with actually handling the parameter storage on the EDM4hep side. This allows to generalize its usage to cases, where apodio::Frame
is not directly accessible, but some other functionality for storing parameters is available.There are multiple ways of solving this but given that the
convertObjectParameters
function is only used in the wrapper I think this is the simplest one even if it changes the interface.edit: removed the tags for the tagging script as this has been reverted again in #105 so it should not end up in the release notes.