Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to MetaHandle #44

Merged
merged 38 commits into from
Nov 6, 2023
Merged

Moving to MetaHandle #44

merged 38 commits into from
Nov 6, 2023

Conversation

ebrondol
Copy link
Collaborator

@ebrondol ebrondol commented Jul 17, 2023

BEGINRELEASENOTES

Fix #45
Currently not needed, but to be fixed in the future: Add CellIDEncodingString to CLUE clusters and CLUE calo hits

@ebrondol
Copy link
Collaborator Author

I have triggered the tests again after key4hep/k4MarlinWrapper#120 was merged in the nightlies, so I was expecting at least the CI on the nightlies to be successful - but this is not the case for now.

@ebrondol
Copy link
Collaborator Author

ebrondol commented Jul 24, 2023

Following the comments of @tmadlener, I have put a few more commits to use MetaDataHandle instead of DataSvc to access to the CellIDEncoding. Locally my code does not successfully run (yet) so there might still be a few things to fix. Any insight can be helpful!

Ps. I expect that the CI mounting /cvmfs/sw.hsf.org/key4hep/setup.sh fails because the package was not included yet in the release.

@ebrondol
Copy link
Collaborator Author

Update:
After the latest commit, I still get the following crash:

TUnixSystem::Di...  FATAL segmentation violation

===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0  0x00007f4a6dfa6659 in waitpid () from /lib64/libc.so.6
#1  0x00007f4a6df23f62 in do_system () from /lib64/libc.so.6
#2  0x00007f4a6df24311 in system () from /lib64/libc.so.6
#3  0x00007f4a68f3c92c in TUnixSystem::Exec (shellcmd=<optimized out>, this=0x26c2970) at /tmp/root/spack-stage/spack-stage-root-6.28.04-gh6xtm6fffjevbywdea32ivuvu63zjdm/spack-src/core/unix/src/TUnixSystem.cxx:2104
#4  TUnixSystem::StackTrace (this=0x26c2970) at /tmp/root/spack-stage/spack-stage-root-6.28.04-gh6xtm6fffjevbywdea32ivuvu63zjdm/spack-src/core/unix/src/TUnixSystem.cxx:2395
#5  0x00007f4a68f3c2f4 in TUnixSystem::DispatchSignals (this=0x26c2970, sig=kSigSegmentationViolation) at /tmp/root/spack-stage/spack-stage-root-6.28.04-gh6xtm6fffjevbywdea32ivuvu63zjdm/spack-src/core/unix/src/TUnixSystem.cxx:3615
#6  <signal handler called>
#7  0x00007f4a4b45bc45 in std::_Function_handler<void (podio::CollectionReadBuffers&), edm4hep::(anonymous namespace)::createBuffers(bool)::{lambda(podio::CollectionReadBuffers&)#2}>::_M_invoke(std::_Any_data const&, podio::CollectionReadBuffers&) () from /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2023-07-22/x86_64-centos7-gcc12.2.0-opt/edm4hep/0a14d8e619e751f537b9a458892e3961bf7fe9b8=develop-otvisy/lib64/libedm4hep.so
#8  0x00007f4a50ab07df in podio::ROOTFrameReader::getCollectionBuffers(podio::ROOTFrameReader::CategoryInfo&, unsigned long, bool, unsigned int) () from /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2023-07-22/x86_64-centos7-gcc12.2.0-opt/podio/6b8eeb1824b0fb19f00b8d581b393282a5542be9=develop-pws3pp/lib64/libpodioRootIO.so
...

@ebrondol ebrondol changed the title Triggering tests WIP: Testing CI & moving to MetaHandle Jul 25, 2023
@ebrondol
Copy link
Collaborator Author

ebrondol commented Aug 7, 2023

Update: I have tested the reco w/CLUE and it works now.
I have included key4hep/k4MarlinWrapper#129 in my tests, it does not work without it.
There is still some problem with the Ntuple/Analyzer which needs to be solved before declaring success.

@ebrondol
Copy link
Collaborator Author

ebrondol commented Aug 9, 2023

Despite the progress made, the command

k4run clue_gaudi_wrapper.py --EventDataSvc.input my_output.root

using as input file the output produced from clicRec_e4h_input.py does not work yet. It gives the following error:

ClueGaudiAlgori...   INFO 1 caloHits in ECAL Barrel.
ClueGaudiAlgori...  FATAL  Standard std::exception is caught 
ClueGaudiAlgori...  ERROR  BitFieldElement: unknown name: layer

@ebrondol ebrondol changed the title WIP: Testing CI & moving to MetaHandle Testing CI & moving to MetaHandle Aug 16, 2023
@ebrondol ebrondol changed the title Testing CI & moving to MetaHandle Moving to MetaHandle Aug 16, 2023
@ebrondol ebrondol requested a review from jmcarcell September 6, 2023 14:03
@ebrondol ebrondol merged commit c856ebc into main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PodioLegacyDataSvc vs PodioDataSvc?
3 participants