-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'declarationFile' instead of #include in CovMatrix component #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the podio PR, we should probably make the CovMatrixCommon.ipp
retrigger CMake by adjusting one of the CMakeLists.txt
I think we also need to install the |
The |
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@m-fila this PR destroyed all automatic testing because the keyword |
As far as I can tell only those workflows which build on an old(ish) version of podio are currently broken. However, there are multiple small changes in EDM4hep that depend on features of podio that came after v00.99 |
this should break only the |
I don't think it's worth fixing the release builds. They effectively just have a podio version that is no longer sufficient. We could put a version requirement into the top level CMakeLists.txt if we wanted to, to make the tests fail earlier. However, since podio v1.0 is very close, I think we just wait with that until we have that. |
BEGINRELEASENOTES
ENDRELEASENOTES
Closes #296
Declarations added with
#include
were not appearing in a documentation generated with doxygen. New podio direcative 'declarationFile' (AIDASoft/podio#601) includes these declaration during file generation without relaying on pre-processor and make them visible to doxygen