Improve python API, use import edm4hep instead of from edm4hep import edm4hep
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
import edm4hepinstead offrom edm4hep import edm4hepENDRELEASENOTES
This simplifies the code internally and also allows us to have TAB completion in an interactive python session. I prefer
import edm4heptofrom edm4hep import edm4hep; I think it makes more sense that you get EDM4hep and its classes directly, and it's the python way of importing a module for almost every module. Then if we add any additional python feature it can be added and imported withfrom edm4hep import feature. This breaksfrom edm4hep import edm4hep, which could be preserved by adding