Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] set EDM4HEP_SET_RPATH ON by default; deduplicate RPATH settings #162

Merged
merged 2 commits into from
Jul 18, 2022
Merged

[cmake] set EDM4HEP_SET_RPATH ON by default; deduplicate RPATH settings #162

merged 2 commits into from
Jul 18, 2022

Conversation

vvolkl
Copy link
Collaborator

@vvolkl vvolkl commented Jul 9, 2022 •
edited by tmadlener
Loading

BEGINRELEASENOTES

  • [cmake] set EDM4HEP_SET_RPATH ON by default
  • [cmake] deduplicate RPATH settings

ENDRELEASENOTES

vvolkl added 2 commits July 9, 2022 15:36
@vvolkl
[cmake] set EDM4HEP_SET_RPATH ON by default
9803b6e 
Since LD_LIBRARY_PATH is no longer set in the default environment of the  key4hep stack (except for ROOT dictionaries) targets must set rpaths to the libraries they depend on to avoid runtime linker errors.
@vvolkl
[cmake] move all RPATH settings to EDM4HEPBuild.cmake
817a8bb 
Removes an accidentally introduced duplication.
tmadlener
tmadlener approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Out of curiosity, did we ever use the old option somewhere in our builds explicitly?

@tmadlener tmadlener merged commit fb3d92b into key4hep:master Jul 18, 2022
@vvolkl vvolkl deleted the cmake branch July 18, 2022 08:26
@vvolkl
Copy link
Collaborator Author

vvolkl commented Jul 18, 2022

No, but it interferred with the RPATH settings that are now mandatory to have when building against the key4hep setup.sh, which no longer sets the LD_LIBRARY_PATH for most things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvolkl @tmadlener