Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This commit addresses issue #519. There are several things to discuss.
I copied and modified the code currently for
urllib3
. I thought this approach is cleaner than adding the code directly forurllib3
, but if there's a better alternative, please let me know.The tests are very limited. At the moment, they only ensure that Docker does not fall into an infinite loop.
As for Docker, there's actually no strong reason to replay it using
vcrpy
. Since the behavior can vary depending on the local environment, replaying it doesn’t seem particularly meaningful. For example, currently I’ve been ignoring cases from Docker using theignore_localhost
option. However, I’m unsure whether it would be better to enforce this approach for others.Let me know your thoughts!