Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline at the end of JSON files #429

Closed
michellelynne opened this issue Apr 29, 2019 · 8 comments
Closed

Newline at the end of JSON files #429

michellelynne opened this issue Apr 29, 2019 · 8 comments

Comments

@michellelynne
Copy link

Cassettes created as JSON do not have a newline at the end. Right now, I manually add it before commiting.

@michellelynne
Copy link
Author

I'd like to take this issue myself, but not sure if it will be valid since it's just style. Thoughts?

@colonelpanic8
Copy link
Collaborator

@michellelynne ending files with a newline is a good idea. e.g. cat doesn't work properly if they don't.

We would happily accept a pull request for this.

@neozenith
Copy link
Collaborator

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant?

If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant.

However if it is still needed, please feel free to re-open or create a new ticket.

Thanks! 🙏

@AaronRobson
Copy link
Contributor

I'll pick this up shortly.

AaronRobson added a commit to AaronRobson/vcrpy that referenced this issue Jan 12, 2020
…rmat

It is a common convention for text files (esp. in Linux) to end with a newline.
AaronRobson added a commit to AaronRobson/vcrpy that referenced this issue Jan 12, 2020
…rmat

It is a common convention for text files (esp. in Linux) to end with a newline.
AaronRobson added a commit to AaronRobson/vcrpy that referenced this issue Jan 12, 2020
…rmat

It is a common convention for text files (esp. in Linux) to end with a newline.
AaronRobson added a commit to AaronRobson/vcrpy that referenced this issue Jan 12, 2020
…rmat

It is a common convention for text files (esp. in Linux) to end with a newline.
@AaronRobson
Copy link
Contributor

Please see PR for a fix and test.

Do the other formats like yaml have the same issue?

@AaronRobson
Copy link
Contributor

@IvanMalison I don't suppose you'd merge the PR for us would you?

@neozenith
Copy link
Collaborator

Hi, I just wanted to update active PRs and issues to let you know I will no longer be an active maintainer on this project.

I recently changed jobs where I no longer use VCRpy or Python at all so I don't have the bandwidth anymore. I won't be monitoring issues or PRs either.

I will have to delegate to other maintainers or ask for some contributors to step up.

I know the Azure CLI uses VCRpy so it would be nice if they could spare some sprint time to maintain this project as it was invaluable in our CI when I was using it.

Kind regards,
Josh

@neozenith
Copy link
Collaborator

@arthurHamon2 this could be a quick win release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants