-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newline at the end of JSON files #429
Comments
I'd like to take this issue myself, but not sure if it will be valid since it's just style. Thoughts? |
@michellelynne ending files with a newline is a good idea. e.g. cat doesn't work properly if they don't. We would happily accept a pull request for this. |
A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant? If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant. However if it is still needed, please feel free to re-open or create a new ticket. Thanks! 🙏 |
I'll pick this up shortly. |
…rmat It is a common convention for text files (esp. in Linux) to end with a newline.
…rmat It is a common convention for text files (esp. in Linux) to end with a newline.
…rmat It is a common convention for text files (esp. in Linux) to end with a newline.
…rmat It is a common convention for text files (esp. in Linux) to end with a newline.
Please see PR for a fix and test. Do the other formats like yaml have the same issue? |
@IvanMalison I don't suppose you'd merge the PR for us would you? |
Hi, I just wanted to update active PRs and issues to let you know I will no longer be an active maintainer on this project. I recently changed jobs where I no longer use VCRpy or Python at all so I don't have the bandwidth anymore. I won't be monitoring issues or PRs either. I will have to delegate to other maintainers or ask for some contributors to step up. I know the Azure CLI uses VCRpy so it would be nice if they could spare some sprint time to maintain this project as it was invaluable in our CI when I was using it. Kind regards, |
@arthurHamon2 this could be a quick win release? |
Cassettes created as JSON do not have a newline at the end. Right now, I manually add it before commiting.
The text was updated successfully, but these errors were encountered: