Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the pie chart labels when there are many states to display #5578 #5971

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

DVUN716
Copy link
Contributor

@DVUN716 DVUN716 commented Nov 18, 2024

I solved that Align the pie chart labels when there are many states to display #5578

If there are too many main labels to display, the donut chart label takes too much space. That's why I only marked at least 4 main labels, and modified the remaining labels to appear and omit through the button.

Press the blue + View More button to display all labels. The button is visible when there are more than 5 labels.
And when all the labels are showing, press the red - View Less button to see only four labels again.
View More
View less

Closed #5578
Closes #6319.

@MilosPaunovic MilosPaunovic self-requested a review November 18, 2024 13:01
@MilosPaunovic MilosPaunovic self-assigned this Nov 18, 2024
@DVUN716
Copy link
Contributor Author

DVUN716 commented Nov 20, 2024

@MilosPaunovic May I know how long it's been going on?

@MilosPaunovic
Copy link
Member

Not sure I get the question there?

@DVUN716
Copy link
Contributor Author

DVUN716 commented Nov 21, 2024

After writing pr and you're in charge of the developer, it's not merging.
I want to know what's wrong with my code, if I'm still reviewing it, and if I'm still reviewing it, I want to know how much it is, and when the merge will be.

@MilosPaunovic
Copy link
Member

It will be merged when I get the chance to review it. And that will happen probably some time next week.

@DVUN716
Copy link
Contributor Author

DVUN716 commented Nov 22, 2024

I see. Thanks.

@MilosPaunovic
Copy link
Member

Hey @DVUN716, I've just got some time to review this properly. Could you please try to resolve conflicts with develop branch first, so I can give it a look? Although it seems quite nice on the screenshots.

@MilosPaunovic MilosPaunovic merged commit f2bfc23 into kestra-io:develop Dec 5, 2024
@MilosPaunovic
Copy link
Member

Thanks for this contribution @DVUN716! 🚀

MilosPaunovic added a commit that referenced this pull request Dec 10, 2024
…present (#5971)

Co-authored-by: MilosPaunovic <paun992@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants