Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token permissions #1580

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Token permissions #1580

merged 2 commits into from
Jan 17, 2025

Conversation

pnacht
Copy link
Contributor

@pnacht pnacht commented Nov 8, 2023

Fixes #1579.

This PR adds read-only permissions to continuous_integration.yml.

It also adds some future-proofing to the other workflows by moving write permissions to job-level instead of top-level, keeping only read-only top-level permissions. This way the added permissions aren't available to other jobs potentially added to the workflows in the future.

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Copy link
Contributor

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@hertschuh hertschuh merged commit 504b5a6 into keras-team:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use read-only permissions in the continuous_integration.yml workflow
3 participants