Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install requirements (socks, urllib3) + minor fixes #90

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Fix install requirements (socks, urllib3) + minor fixes #90

merged 2 commits into from
Oct 21, 2021

Conversation

mmac-m3a
Copy link
Contributor

Require requests with support for SOCKS
The SDK code depends Retry object version introduced in urllib3 1.26.0
Do not retry on 500 status
Minor fixes in flatness analysis

martin added 2 commits September 10, 2021 00:51
Always install requests with socks
Fixed typo and minor bug in flatness analysis
Retry object has changed in version 1.26.0 and the SDK relies on the new version
Copy link
Collaborator

@bernardoVale bernardoVale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmac-m3a mmac-m3a merged commit 615ca71 into kentik:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants