Skip to content

Commit

Permalink
Better fix for package versioning (#104)
Browse files Browse the repository at this point in the history
* Force setuptools_scm to be installed

Turns out that `python setup.py build bdist_wheel` does not install `setuptools_scm` despite them being listed in `pyproject.toml` in `[build_system][requires]`. This changes forces the installation.
  • Loading branch information
mmac-m3a authored Jan 15, 2022
1 parent 368259d commit d6ee4c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion kentik_api_library/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[tool.setuptools_scm]
root = ".."
relative_to = "."
relative_to = "__file__"

[tool.black]
line-length = 120
Expand Down
1 change: 1 addition & 0 deletions kentik_api_library/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ def _isort(self) -> None:
license="Apache-2.0",
include_package_data=True,
python_requires=">=3.8, <4",
setup_requires=["setuptools_scm"],
install_requires=["dacite>=1.6.0", "requests[socks]>=2.25.0", "typing-extensions>=3.7.4.3", "urllib3>=1.26.0"],
tests_require=["httpretty", "pytest", "pylint"],
extras_require={"analytics": ["pandas>=1.2.4", "pyyaml>=5.4.1", "fastparquet>=0.6.3"]},
Expand Down

0 comments on commit d6ee4c4

Please sign in to comment.