Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant space to fix release job #5

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Remove redundant space to fix release job #5

merged 1 commit into from
Dec 25, 2022

Conversation

nivgsk
Copy link
Collaborator

@nivgsk nivgsk commented Dec 25, 2022

No description provided.

giladgurvich
giladgurvich approved these changes Dec 25, 2022
View reviewed changes
Copy link

@giladgurvich giladgurvich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this help? 🤞

@nivgsk
Copy link
Collaborator Author

nivgsk commented Dec 25, 2022

@giladgurvich It should 😅
The space was added to the docker build tags after a "-", causing the tag to be read as a flag

@nivgsk nivgsk merged commit a6b0722 into master Dec 25, 2022
@nivgsk nivgsk deleted the fix-for-release branch December 25, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgurvich giladgurvich giladgurvich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nivgsk @giladgurvich