Group inline snapshot transform results by env (#118)

* Group inline snapshot transform results by env * Prefix env list with BABEL_ENV
kensho-technologies · Jun 8, 2021 · be57960 · be57960
1 parent a401937
commit be57960
Show file tree

Hide file tree

Showing 10 changed files with 109 additions and 112 deletions.
diff --git a/__tests__/modules.ts b/__tests__/modules.ts
@@ -9,25 +9,13 @@ test('static imports', () => {
     console.log(defaultExport, namedExport, namespace)
   `
 
-  expect(transform({code, env: 'development'})).toMatchInlineSnapshot(`
+  expect(transform({code})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
     import defaultExport, {namedExport} from 'foo'
     import * as namespace from 'bar'
     console.log(defaultExport, namedExport, namespace)
-  `)
-
-  expect(transform({code, env: 'production'})).toMatchInlineSnapshot(`
-    import defaultExport, {namedExport} from 'foo'
-    import * as namespace from 'bar'
-    console.log(defaultExport, namedExport, namespace)
-  `)
-
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(`
-    import defaultExport, {namedExport} from 'foo'
-    import * as namespace from 'bar'
-    console.log(defaultExport, namedExport, namespace)
-  `)
 
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var _interopRequireWildcard = require('@babel/runtime/helpers/interopRequireWildcard').default
     var _foo = _interopRequireWildcard(require('foo'))
@@ -39,10 +27,11 @@ test('static imports', () => {
 test('dynamic imports', () => {
   const code = `import('foo')`
 
-  expect(transform({code, env: 'development'})).toMatchInlineSnapshot(`import('foo')`)
-  expect(transform({code, env: 'production'})).toMatchInlineSnapshot(`import('foo')`)
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(`import('foo')`)
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`
+  expect(transform({code})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
+    import('foo')
+
+    // BABEL_ENV cjs:
     'use strict'
     var _interopRequireDefault = require('@babel/runtime/helpers/interopRequireDefault').default
     var _interopRequireWildcard2 = _interopRequireDefault(
@@ -61,33 +50,23 @@ test('static exports', () => {
     export * as baz from 'other'
   `
 
-  expect(transform({code, env: 'development'})).toMatchInlineSnapshot(`
+  expect(transform({code})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production:
     var foo = 1
     export default foo
     export {foo}
     export {bar} from 'other'
     import * as _baz from 'other'
     export {_baz as baz}
-  `)
 
-  expect(transform({code, env: 'production'})).toMatchInlineSnapshot(`
-    var foo = 1
-    export default foo
-    export {foo}
-    export {bar} from 'other'
-    import * as _baz from 'other'
-    export {_baz as baz}
-  `)
-
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(`
+    // BABEL_ENV esm:
     const foo = 1
     export default foo
     export {foo}
     export {bar} from 'other'
     export * as baz from 'other'
-  `)
 
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var _interopRequireWildcard = require('@babel/runtime/helpers/interopRequireWildcard').default
     Object.defineProperty(exports, '__esModule', {value: true})

diff --git a/__tests__/polyfills.ts b/__tests__/polyfills.ts
@@ -4,30 +4,34 @@ import transform from '../helpers/transform'
 
 test('removes polyfill imports in libraries', () => {
   const code = `import 'core-js/stable'`
+  const envs = ['esm', 'cjs']
 
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(``)
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`'use strict'`)
+  expect(transform({code, envs})).toMatchInlineSnapshot(`
+    // BABEL_ENV esm:
+
+    // BABEL_ENV cjs:
+    'use strict'
+  `)
 })
 
 test('narrows polyfill imports in apps with modern targets', () => {
   const code = `import 'core-js/stable'`
   const targets = 'Chrome 90'
+  const envs = ['development', 'production']
 
-  const development = transform({code, targets, env: 'development'})
-  const production = transform({code, targets, env: 'production'})
-  expect(development).toBe(production)
-  expect(development).toMatchInlineSnapshot(`import 'core-js/modules/web.immediate.js'`)
+  expect(transform({code, targets, envs})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production:
+    import 'core-js/modules/web.immediate.js'
+  `)
 })
 
 test('narrows polyfill imports in apps with legacy targets', () => {
   const code = `import 'core-js/stable'`
   const targets = 'Chrome 60'
+  const envs = ['development', 'production']
 
-  const development = transform({code, targets, env: 'development'})
-  const production = transform({code, targets, env: 'production'})
-  expect(development).toBe(production)
-
-  expect(development).toMatchInlineSnapshot(`
+  expect(transform({code, targets, envs})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production:
     import 'core-js/modules/es.symbol.description.js'
     import 'core-js/modules/es.symbol.async-iterator.js'
     import 'core-js/modules/es.array.flat.js'

diff --git a/__tests__/react-classic.ts b/__tests__/react-classic.ts
@@ -17,7 +17,8 @@ test('transpiles JSX using classic runtime', () => {
     }
   `
 
-  expect(transform({code, options, env: 'development'})).toMatchInlineSnapshot(`
+  expect(transform({code, options})).toMatchInlineSnapshot(`
+    // BABEL_ENV development:
     var _jsxFileName = '/file.js',
       _s = $RefreshSig$()
     import * as React from 'react'
@@ -42,9 +43,8 @@ test('transpiles JSX using classic runtime', () => {
     _c = MyComponent
     var _c
     $RefreshReg$(_c, 'MyComponent')
-  `)
 
-  expect(transform({code, options, env: 'production'})).toMatchInlineSnapshot(`
+    // BABEL_ENV production:
     import * as React from 'react'
     function MyComponent() {
       React.useEffect(function () {}, [])
@@ -56,9 +56,8 @@ test('transpiles JSX using classic runtime', () => {
         ' bar'
       )
     }
-  `)
 
-  expect(transform({code, options, env: 'esm'})).toMatchInlineSnapshot(`
+    // BABEL_ENV esm:
     import * as React from 'react'
     function MyComponent() {
       React.useEffect(() => {}, [])
@@ -70,9 +69,8 @@ test('transpiles JSX using classic runtime', () => {
         ' bar'
       )
     }
-  `)
 
-  expect(transform({code, options, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var _interopRequireWildcard = require('@babel/runtime/helpers/interopRequireWildcard').default
     var React = _interopRequireWildcard(require('react'))

diff --git a/__tests__/react.ts b/__tests__/react.ts
@@ -16,7 +16,8 @@ test('transpiles JSX', () => {
     }
   `
 
-  expect(transform({code, env: 'development'})).toMatchInlineSnapshot(`
+  expect(transform({code})).toMatchInlineSnapshot(`
+    // BABEL_ENV development:
     var _jsxFileName = '/file.js',
       _s = $RefreshSig$()
     import {useState} from 'react'
@@ -50,9 +51,8 @@ test('transpiles JSX', () => {
     _c = MyComponent
     var _c
     $RefreshReg$(_c, 'MyComponent')
-  `)
 
-  expect(transform({code, env: 'production'})).toMatchInlineSnapshot(`
+    // BABEL_ENV production:
     import {useState} from 'react'
     import {jsx as _jsx} from 'react/jsx-runtime'
     import {jsxs as _jsxs} from 'react/jsx-runtime'
@@ -63,9 +63,8 @@ test('transpiles JSX', () => {
         Object.assign({height: 2}, rest, {children: [/*#__PURE__*/ _jsx('div', {}), 'foo', ' bar']})
       )
     }
-  `)
 
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(`
+    // BABEL_ENV esm:
     import {useState} from 'react'
     import {jsx as _jsx} from 'react/jsx-runtime'
     import {jsxs as _jsxs} from 'react/jsx-runtime'
@@ -77,9 +76,8 @@ test('transpiles JSX', () => {
         children: [/*#__PURE__*/ _jsx('div', {}), 'foo', ' bar'],
       })
     }
-  `)
 
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var _react = require('react')
     var _jsxRuntime = require('react/jsx-runtime')

diff --git a/__tests__/runtime.ts b/__tests__/runtime.ts
@@ -7,22 +7,15 @@ const targets = 'IE 11' // ensures that a helper is required to transpile the re
 
 test('imports external runtime helpers by default', () => {
   const options = {targets}
-  const development = transform({code, options, env: 'development'})
-  const production = transform({code, options, env: 'production'})
-  const esm = transform({code, options, env: 'esm'})
-  const cjs = transform({code, options, env: 'cjs'})
 
-  expect(development).toMatchInlineSnapshot(`
+  expect(transform({code, options})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
     import _objectWithoutPropertiesLoose from '@babel/runtime/helpers/objectWithoutPropertiesLoose'
     var _obj = obj,
       foo = _obj.foo,
       rest = _objectWithoutPropertiesLoose(_obj, ['foo'])
-  `)
-
-  expect(production).toBe(development)
-  expect(esm).toBe(development)
 
-  expect(cjs).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var _interopRequireDefault = require('@babel/runtime/helpers/interopRequireDefault').default
     var _objectWithoutPropertiesLoose2 = _interopRequireDefault(
@@ -36,12 +29,9 @@ test('imports external runtime helpers by default', () => {
 
 test('injects runtime helpers when `runtime` is disabled', () => {
   const options = {targets, runtime: false}
-  const development = transform({code, options, env: 'development'})
-  const production = transform({code, options, env: 'production'})
-  const esm = transform({code, options, env: 'esm'})
-  const cjs = transform({code, options, env: 'cjs'})
 
-  expect(development).toMatchInlineSnapshot(`
+  expect(transform({code, options})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
     function _objectWithoutPropertiesLoose(source, excluded) {
       if (source == null) return {}
       var target = {}
@@ -57,12 +47,8 @@ test('injects runtime helpers when `runtime` is disabled', () => {
     var _obj = obj,
       foo = _obj.foo,
       rest = _objectWithoutPropertiesLoose(_obj, ['foo'])
-  `)
-
-  expect(production).toBe(development)
-  expect(esm).toBe(development)
 
-  expect(cjs).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     function _objectWithoutPropertiesLoose(source, excluded) {
       if (source == null) return {}

diff --git a/__tests__/syntax.ts b/__tests__/syntax.ts
@@ -13,7 +13,8 @@ test('class properties', () => {
     }
   `
 
-  expect(transform({code, env: 'development'})).toMatchInlineSnapshot(`
+  expect(transform({code})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production:
     import _classPrivateFieldLooseKey from '@babel/runtime/helpers/classPrivateFieldLooseKey'
     var _privateMethod = /*#__PURE__*/ _classPrivateFieldLooseKey('privateMethod')
     var Foo = function Foo() {
@@ -26,19 +27,17 @@ test('class properties', () => {
       return 1
     }
     Foo.bar = 'abc'
-  `)
 
-  expect(transform({code, env: 'esm'})).toMatchInlineSnapshot(`
+    // BABEL_ENV esm:
     class Foo {
       static bar = 'abc'
       baz = (x, y) => x({...y})
       #privateMethod() {
         return 1
       }
     }
-  `)
 
-  expect(transform({code, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     class Foo {
       static bar = 'abc'

diff --git a/__tests__/typescript.ts b/__tests__/typescript.ts
@@ -3,26 +3,28 @@ import {test, expect} from '@jest/globals'
 import transform from '../helpers/transform'
 
 test('strips type annotations in .ts files', () => {
-  const filename = 'file.ts'
   const code = `var one: number = 1`
+  const filename = 'file.ts'
+
+  expect(transform({code, filename})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
+    var one = 1
 
-  expect(transform({code, filename, env: 'development'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'production'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'esm'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var one = 1
   `)
 })
 
 test('strips type annotations in .tsx files', () => {
-  const filename = 'file.tsx'
   const code = `var one: number = 1`
+  const filename = 'file.tsx'
+
+  expect(transform({code, filename})).toMatchInlineSnapshot(`
+    // BABEL_ENV development, production, esm:
+    var one = 1
 
-  expect(transform({code, filename, env: 'development'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'production'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'esm'})).toMatchInlineSnapshot(`var one = 1`)
-  expect(transform({code, filename, env: 'cjs'})).toMatchInlineSnapshot(`
+    // BABEL_ENV cjs:
     'use strict'
     var one = 1
   `)

diff --git a/helpers/groupBy.ts b/helpers/groupBy.ts
@@ -0,0 +1,12 @@
+export default function groupBy<T, K>(items: T[], iteratee: (item: T) => K): Map<K, T[]> {
+  const groups = new Map<K, T[]>()
+
+  items.forEach((item) => {
+    const key = iteratee(item)
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    if (groups.has(key)) groups.get(key)!.push(item)
+    else groups.set(key, [item])
+  })
+
+  return groups
+}
diff --git a/helpers/serializer.ts b/helpers/serializer.ts
@@ -1,10 +1,6 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
-import {format, resolveConfig} from 'prettier'
-
-const prettierConfig = resolveConfig.sync(__dirname)
-if (!prettierConfig) throw new Error()
-
 module.exports = {
   test: (val: string) => typeof val === 'string',
-  serialize: (val: string) => format(val, {...prettierConfig, parser: 'babel'}).trim(),
+  serialize: (val: string) => val,
 }
+
+export {}