chore(svg): Reduce size of SVG output #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Sep 26, 2024
src/render/svg.rs
Outdated
| @@ -51,7 +51,7 @@ impl<'a> RenderCanvas for Canvas<'a> { | |||
| r#"<svg xmlns="http://www.w3.org/2000/svg""#, | |||
| r#" version="1.1" width="{w}" height="{h}""#, | |||
| r#" viewBox="0 0 {w} {h}" shape-rendering="crispEdges">"#, | |||
| r#"<rect x="0" y="0" width="{w}" height="{h}" fill="{bg}"/>"#, | |||
| r#"<path d="M0 0h{w}v{h}h-{w}z" fill="{bg}"/>"#, | |||
There was a problem hiding this comment.
Suggested change
| r#"<path d="M0 0h{w}v{h}h-{w}z" fill="{bg}"/>"#, | |
| r#"<path d="M0 0h{w}v{h}H0z" fill="{bg}"/>"#, |
this should be even shorter? 🤔
There was a problem hiding this comment.
Which is better "M{left} {top}h{width}v{height}h-{width}z" or "M{left} {top}h{width}v{height}H{left}z"?
There was a problem hiding this comment.
@sorairolake if left < width * 10 use H{left} otherwise h-{width}.
but always using h-{width} should compress better.
kennytm
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qrcode-rust/src/render/svg.rs
Line 54 in 85b51f5
can also be represented as
qrcode-rust/src/render/svg.rs
Line 71 in 85b51f5
can also be represented as
With these changes, file size of the output SVG is reduced.