Skip to content

Commit

Permalink
fix(styles): downgrade sass version as there is an issue with @extend (
Browse files Browse the repository at this point in the history
…carbon-design-system#9973)

### Related Ticket(s)

{{Provide url(s) to the related ticket(s) that this pull request addresses}}

### Description

There seems to be an issue with `@extend` in the recent upgrade of `sass`. Downgrading `sass` version until there is fix

### Changelog

**Changed**

- downgrade sass back to `~1.40.0`

**Removed**

- band-aid fixes that should be resolved with the `sass` downgrade

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
  • Loading branch information
annawen1 authored Jan 31, 2023
1 parent bfb3d6a commit e7f12c9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion web-components/packages/carbon-web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
"rollup-plugin-multi-input": "^1.3.1",
"rollup-plugin-terser": "^7.0.2",
"rtlcss": "^3.0.0",
"sass": "~1.57.0",
"sass": "~1.40.0",
"sass-loader": "^10.0.0",
"strip-comments": "^1.0.0",
"style-loader": "^2.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ $css--plex: true !default;

:host(#{$prefix}-breadcrumb-item) {
@extend .#{$prefix}--breadcrumb-item;

// TODO: see if we can remove this ::after section after v11 upgrade
&::after {
margin-left: $spacing-03;
color: $text-primary;
content: '/';
}
}

:host(#{$prefix}-breadcrumb-overflow-menu) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@

:host(#{$prefix}-modal[open]) {
@extend .#{$prefix}--modal, .is-visible;

// TODO: look into if following two lines are necessary after v11 upgrade
opacity: 1;
visibility: inherit;
}

:host(#{$prefix}-modal-header) {
Expand Down

0 comments on commit e7f12c9

Please sign in to comment.