OpenCL dynamic runtime support added #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitry-zakablukov please can you change this PR to use the current develop branch? |
|
@kenba , okay, but it will take some time. |
# Conflicts: # Cargo.toml # src/command_queue.rs # src/d3d10.rs # src/d3d11.rs # src/dx9_media_sharing.rs # src/egl.rs # src/error_codes.rs # src/gl.rs # src/lib.rs # src/memory.rs # src/platform.rs # src/program.rs # src/runtime/mod.rs
|
@kenba , I have updated the pr, but I cannot check compilation with the current version of Can you please apply this patch to In this patch all extern system functions are under the |
|
@dmitry-zakablukov I've applied your patch to the develop branch. |
95765ed to
7f113bd
Compare
|
@kenba , thanks. I have updated the pr, all tests and examples can be compiled without errors now. |
|
Thanks @dmitry-zakablukov merged in now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a feature
dynamic-runtimeto load the OpenCL library in the runtime and avoid linkage errors during compilation stage (OpenCL.lib not found).I have checked that there is no compilation warnings with both runtimes and with default and full features sets. I also have checked that
opencl3library can be compiled with my changes (there are only two warnings about unusedResult).Tests are passing using the command
cargo test --all-features -- --test-threads=1.