HiveScans/Toons: Fix PageListParse #7640
Open
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetleledaal
reviewed
Feb 13, 2025
| @@ -20,6 +22,14 @@ class HiveScans : Iken( | |||
| } | |||
| .build() | |||
|
|
|||
| val PageRegex = Regex("""https://storage.\w+.\w+/public//upload/series/(\w+)/(\w+)/(\d+).webp""") | |||
There was a problem hiding this comment.
Is the double slash intentional? Is that something that should be optional in case they fix it?
Unrelated, but we should really have some kind of helper functions to parse next.js' RSC.
There was a problem hiding this comment.
Also regex will fail if the slug of the series contains special characters.
\\\"images\\\":(\[.*?]).*?nextChapterthis regex captures the entire array; you will need to unescape and deserialize it.
6dbc5c5 to
bb78581
Compare
|
Not sure if there is a better way to unescape, but it works. And just ignore the Force Push, i pressed a button i shouldn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Closes #7531
overrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsidif a source's name or language were changed