Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable backoff factor and backoff max #215

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

psaia
Copy link
Contributor

@psaia psaia commented May 22, 2024

Initial problem

We'd like to run tests with variable run-durations more frequently. This can be almost accomplished by setting a more rapid cron (e.g. 30s) along side a much longer windowtimeout.

However, when using a larger windowtimeout w/ the previously hard-coded backoff factor, it can create a significant delay before the HC status is actually updated.

Changes

  • Allow for the max and min retry timeout to be customizable (to make it non exponential)
  • Allow for the retry factor to be customizable
  • Add clearer log indicating a workflow for a HC cannot be found
  • Misc. code linting

@psaia psaia requested a review from a team as a code owner May 22, 2024 19:01
@psaia psaia force-pushed the allow-flexible-backoffs branch from 680b374 to 573d8d7 Compare May 22, 2024 19:47
…am@petesaia.com>

Signed-off-by: Pete Saia <pete.saia@nytimes.com>
@psaia psaia force-pushed the allow-flexible-backoffs branch from 573d8d7 to 4fcad60 Compare May 22, 2024 19:49
Signed-off-by: Pete Saia <iam@petesaia.com>
@psaia psaia force-pushed the allow-flexible-backoffs branch from 00cf64f to 08889a1 Compare May 23, 2024 19:46
psaia added 2 commits May 23, 2024 15:50
Signed-off-by: Pete Saia <iam@petesaia.com>
Signed-off-by: Pete Saia <iam@petesaia.com>
@psaia
Copy link
Contributor Author

psaia commented May 30, 2024

@tekenstam (Sorry, pinging you due to recent activity) - Is there anything further I can do to have this PR reviewed?

@tekenstam tekenstam requested review from RaviHari and tekenstam June 13, 2024 18:17
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.99%. Comparing base (2ff4c95) to head (809e21f).
Report is 10 commits behind head on master.

Files Patch % Lines
internal/controllers/healthcheck_controller.go 76.92% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   65.64%   67.99%   +2.35%     
==========================================
  Files           3        3              
  Lines        1141      978     -163     
==========================================
- Hits          749      665      -84     
+ Misses        313      232      -81     
- Partials       79       81       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tekenstam tekenstam merged commit 415dc30 into keikoproj:master Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants