Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-controller and argoexec to v3.4.4 #133

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

sasagarw
Copy link
Contributor

@sasagarw sasagarw commented Dec 7, 2022

Signed-off-by: Sashank Agarwal sashankagarwal97@gmail.com

Fixes issue #132

Proposed Changes

  • Updates workflow-controller to v3.4.4
  • Updates argoexec to v3.4.4
  • Adds new CRD
  • Updates RBAC
  • Resolves multiple CVEs

Testing Done

Functional Test

Using cached envtest tools from /Users/sagarwal23/Desktop/Intuit/active-monitor/testbin
setting up env vars
ok      github.com/keikoproj/active-monitor/api/v1alpha1        10.510s coverage: 0.8% of statements
ok      github.com/keikoproj/active-monitor/controllers 35.445s coverage: 66.3% of statements
ok      github.com/keikoproj/active-monitor/metrics     4.038s  coverage: 81.8% of statements
?       github.com/keikoproj/active-monitor/store       [no test files]

Logs

time="2022-12-07T09:43:59.357Z" level=info msg="Processing workflow" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.359Z" level=info msg="Task-result reconciliation" namespace=addon-active-monitor-ns numObjs=0 workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.359Z" level=warning msg="workflow uses legacy/insecure pod patch, see https://argoproj.github.io/argo-workflows/workflow-rbac/" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.359Z" level=info msg="node changed" namespace=addon-active-monitor-ns new.message= new.phase=Succeeded new.progress=0/1 nodeID=dns-healthcheck-workflow-mhw7n-3587066030 old.message= old.phase=Pending old.progress=0/1 workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.360Z" level=info msg="SG Outbound nodes of dns-healthcheck-workflow-mhw7n-1049159460 are [dns-healthcheck-workflow-mhw7n-1049159460]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.360Z" level=info msg="SG Outbound nodes of dns-healthcheck-workflow-mhw7n-10348342 are [dns-healthcheck-workflow-mhw7n-10348342]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.360Z" level=info msg="Step group node dns-healthcheck-workflow-mhw7n-3073224799 successful" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:43:59.360Z" level=info msg="node dns-healthcheck-workflow-mhw7n-3073224799 phase Running -> Succeeded" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n

time="2022-12-07T09:44:09.409Z" level=info msg="Processing workflow" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.410Z" level=info msg="Task-result reconciliation" namespace=addon-active-monitor-ns numObjs=0 workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.410Z" level=warning msg="workflow uses legacy/insecure pod patch, see https://argoproj.github.io/argo-workflows/workflow-rbac/" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.410Z" level=info msg="node changed" namespace=addon-active-monitor-ns new.message= new.phase=Succeeded new.progress=0/1 nodeID=dns-healthcheck-workflow-mhw7n-468232766 old.message= old.phase=Pending old.progress=0/1 workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.411Z" level=info msg="SG Outbound nodes of dns-healthcheck-workflow-mhw7n-1049159460 are [dns-healthcheck-workflow-mhw7n-1049159460]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.411Z" level=info msg="SG Outbound nodes of dns-healthcheck-workflow-mhw7n-10348342 are [dns-healthcheck-workflow-mhw7n-10348342]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.411Z" level=info msg="SG Outbound nodes of dns-healthcheck-workflow-mhw7n-3587066030 are [dns-healthcheck-workflow-mhw7n-3587066030]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="Step group node dns-healthcheck-workflow-mhw7n-4214249986 successful" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="node dns-healthcheck-workflow-mhw7n-4214249986 phase Running -> Succeeded" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="node dns-healthcheck-workflow-mhw7n-4214249986 finished: 2022-12-07 09:44:09.412068433 +0000 UTC" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="Outbound nodes of dns-healthcheck-workflow-mhw7n-468232766 is [dns-healthcheck-workflow-mhw7n-468232766]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="Outbound nodes of dns-healthcheck-workflow-mhw7n is [dns-healthcheck-workflow-mhw7n-468232766]" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="node dns-healthcheck-workflow-mhw7n phase Running -> Succeeded" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="node dns-healthcheck-workflow-mhw7n finished: 2022-12-07 09:44:09.41223674 +0000 UTC" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="Checking daemoned children of dns-healthcheck-workflow-mhw7n" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n
time="2022-12-07T09:44:09.412Z" level=info msg="TaskSet Reconciliation" namespace=addon-active-monitor-ns workflow=dns-healthcheck-workflow-mhw7n

time="2022-12-07T09:46:25.365Z" level=info msg="Create events 201"
time="2022-12-07T09:46:25.369Z" level=info msg="Create events 201"
time="2022-12-07T09:46:25.374Z" level=info msg="Create events 201"
time="2022-12-07T09:46:25.377Z" level=info msg="Create events 201"
time="2022-12-07T09:46:26.000Z" level=info msg="Deleting garbage collected workflow 'addon-active-monitor-ns/dns-hostnetwork-healthcheck-workflow-njkpg'"
time="2022-12-07T09:46:26.010Z" level=info msg="Delete workflows 200"
time="2022-12-07T09:46:26.010Z" level=info msg="Successfully deleted 'addon-active-monitor-ns/dns-hostnetwork-healthcheck-workflow-njkpg'"

Signed-off-by: Sashank Agarwal <sashankagarwal97@gmail.com>
@sasagarw sasagarw requested a review from a team as a code owner December 7, 2022 09:47
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #133 (6807cf5) into master (1eca2ad) will decrease coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   63.40%   61.75%   -1.65%     
==========================================
  Files           3        3              
  Lines         910      910              
==========================================
- Hits          577      562      -15     
- Misses        247      261      +14     
- Partials       86       87       +1     
Impacted Files Coverage Δ
controllers/healthcheck_controller.go 61.45% <0.00%> (-1.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RaviHari RaviHari merged commit 98cd152 into keikoproj:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants