Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.18 #112

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Update go to 1.18 #112

merged 2 commits into from
Jul 13, 2022

Conversation

sasagarw
Copy link
Contributor

Signed-off-by: Sashank Agarwal sashankagarwal97@gmail.com

Fixes issue #111

Proposed Changes

  • Update go version to 1.18
  • Use make targets for setting up kubebuilder

Testing Done

Functional Tests:

setting up env vars
ok      github.com/keikoproj/active-monitor/api/v1alpha1        7.935s  coverage: 0.8% of statements
ok      github.com/keikoproj/active-monitor/controllers 32.873s coverage: 67.0% of statements
ok      github.com/keikoproj/active-monitor/metrics     0.824s  coverage: 81.8% of statements
?       github.com/keikoproj/active-monitor/store       [no test files]

Docker build image using go1.18:

docker build . -t keikoproj/active-monitor:latest -t keikoproj/active-monitor:latest
[+] Building 64.7s (19/19) FINISHED                                                                                                                                                                                                     
 => [internal] load build definition from Dockerfile                                                                                                                                                                               0.0s
 => => transferring dockerfile: 914B                                                                                                                                                                                               0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                                                    0.0s
 => [internal] load metadata for gcr.io/distroless/static:latest                                                                                                                                                                   3.5s
 => [internal] load metadata for docker.io/library/golang:1.18                                                                                                                                                                     3.8s
 => [builder  1/11] FROM docker.io/library/golang:1.18@sha256:a452d6273ad03a47c2f29b898d6bb57630e77baf839651ef77d03e4e049c5bf3                                                                                                     0.0s
 => [internal] load build context                                                                                                                                                                                                  0.0s
 => => transferring context: 147.80kB                                                                                                                                                                                              0.0s
 => [stage-1 1/3] FROM gcr.io/distroless/static:latest@sha256:21d3f84a4f37c36199fd07ad5544dcafecc17776e3f3628baf9a57c8c0181b3f                                                                                                     2.1s
 => => resolve gcr.io/distroless/static:latest@sha256:21d3f84a4f37c36199fd07ad5544dcafecc17776e3f3628baf9a57c8c0181b3f                                                                                                             0.0s
 => => sha256:21d3f84a4f37c36199fd07ad5544dcafecc17776e3f3628baf9a57c8c0181b3f 1.67kB / 1.67kB                                                                                                                                     0.0s
 => => sha256:ce02701f96fe64fda4d82afba2429aa048e08acbb8b1ecf991da872fafe672ad 426B / 426B                                                                                                                                         0.0s
 => => sha256:fad7103772a21bcff605c8e2ef9502d505a7b5aa72fc455ca892aa32d44b0560 462B / 462B                                                                                                                                         0.0s
 => => sha256:9880fb5de7c72b0f434dc16d69a5083c77d3b0fc79b0f4f3faafb10070db91a6 804.10kB / 804.10kB                                                                                                                                 2.0s
 => => extracting sha256:9880fb5de7c72b0f434dc16d69a5083c77d3b0fc79b0f4f3faafb10070db91a6                                                                                                                                          0.1s
 => CACHED [builder  2/11] WORKDIR /workspace                                                                                                                                                                                      0.0s
 => [builder  3/11] COPY go.mod go.mod                                                                                                                                                                                             0.0s
 => [builder  4/11] COPY go.sum go.sum                                                                                                                                                                                             0.0s
 => [builder  5/11] RUN go mod download                                                                                                                                                                                           44.3s
 => [builder  6/11] COPY main.go main.go                                                                                                                                                                                           0.0s
 => [builder  7/11] COPY api/ api/                                                                                                                                                                                                 0.0s
 => [builder  8/11] COPY controllers/ controllers/                                                                                                                                                                                 0.0s
 => [builder  9/11] COPY metrics/ metrics/                                                                                                                                                                                         0.0s
 => [builder 10/11] COPY store/ store/                                                                                                                                                                                             0.0s
 => [builder 11/11] RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o active-monitor-controller main.go                                                                                                     16.1s
 => [stage-1 2/3] COPY --from=builder /workspace/active-monitor-controller .                                                                                                                                                       0.1s
 => exporting to image                                                                                                                                                                                                             0.1s
 => => exporting layers                                                                                                                                                                                                            0.1s
 => => writing image sha256:2a6847bfee0643bbb1f82d1d335baee88a36d838fceeea2a4ea3b5c0d494837b                                                                                                                                       0.0s
 => => naming to docker.io/keikoproj/active-monitor:latest                                                                                                                                                                         0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
updating kustomize image patch file for manager resource
sed -i'' -e 's@image: .*@image: '"keikoproj/active-monitor:latest"'@' ./config/default/manager_image_patch.yaml

Signed-off-by: Sashank Agarwal <sashankagarwal97@gmail.com>
@sasagarw sasagarw requested a review from a team as a code owner July 12, 2022 05:19
Signed-off-by: Sashank Agarwal <sashankagarwal97@gmail.com>
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #112 (098271e) into master (1490176) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   60.83%   61.29%   +0.46%     
==========================================
  Files           3        3              
  Lines         863      863              
==========================================
+ Hits          525      529       +4     
+ Misses        252      249       -3     
+ Partials       86       85       -1     
Impacted Files Coverage Δ
controllers/healthcheck_controller.go 60.95% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1490176...098271e. Read the comment docs.

@RaviHari RaviHari merged commit 46b3449 into keikoproj:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants