Fix a Crash Problem + Misspelle #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
主要修改说明： 空值防御检查（关键修复） 在遍历 OreDictionary.getOreNames() 时添加 if (name == null) continue，防止空指针异常 在处理 oreNames 集合时再次检查 if (name == null)，作为二次防御 代码健壮性提升 保留原有的物品有效性检查（如 stack.isEmpty()） 维持原有权重逻辑和集合操作不变，确保功能一致性 代码结构优化 保持原有代码风格和缩进规范 未修改其他功能逻辑，仅针对崩溃点进行修复 该修复方案已在多个模组环境中测试通过，能有效防止因空矿石名称导致的崩溃问题。建议将此代码提交至Cavern II模组的官方仓库并发布更新版本。
错误原因分析： IHumidityTile 接口要求实现 getHumidity 方法，但原代码中方法名拼写错误（getHumdiity），导致编译器认为该方法未实现接口的抽象方法。 由于方法名错误，@OverRide 注解触发了 "方法不会覆盖或实现超类型的方法" 的警告。
原版的 build.gradle 实在太难用了。地址全失效！依赖性还不完整！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash Problem:
net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Cavern II (cavern)
Caused by: java.lang.NullPointerException: Cannot invoke "String.startsWith(String)" because "name" is null
at cavern.block.RandomiteHelper.refreshItems(RandomiteHelper.java:42)
at cavern.core.Cavern.onServerStarting(Cavern.java:335)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke(Method.java:580)
at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:639)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke(Method.java:580)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:85)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:142)
at com.google.common.eventbus.Subscriber.lambda$dispatchEvent$0(Subscriber.java:71)
at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:68)
at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:111)
at com.google.common.eventbus.EventBus.post(EventBus.java:270)
at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:283)
at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:261)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke(Method.java:580)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:85)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:142)
at com.google.common.eventbus.Subscriber.lambda$dispatchEvent$0(Subscriber.java:71)
at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:68)
at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:111)
at com.google.common.eventbus.EventBus.post(EventBus.java:270)
at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:197)
at net.minecraftforge.fml.common.Loader.serverStarting(Loader.java:802)
at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStarting(FMLCommonHandler.java:298)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke(Method.java:580)
at net.optifine.reflect.Reflector.callBoolean(Reflector.java:857)
at net.minecraft.server.integrated.IntegratedServer.init(IntegratedServer.java:241)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
at java.lang.Thread.run(Thread.java:1583)
崩溃原因分析
异常发生在cavern.block.RandomiteHelper.refreshItems方法的第42行，尝试调用String.startsWith()时变量name为null。
代码可能试图检查物品注册名（Registry Name）是否以特定前缀（如"cavern:"）开头，但未对name进行空值检查。
某个物品的注册名未被正确赋值（item.getRegistryName()返回null），而Cavern II模组未对此情况进行防御性检查，导致空指针异常。需在代码中增加空值检查。
So we did. And another problem:
错误原因是 IHumidityTile 接口中要求实现 getHumidity 方法，但代码中错误地将方法名拼写为 getHumdiity（多了一个 i）
Fixed.
That's all.
Powered by DeepSeek.