Implement autoreload of database file #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the database if modified by an other instance of KeePassX, KeePassX detect it and reload automatically the database.
Conflicts: src/gui/DatabaseWidget.cpp
# Conflicts: # src/gui/DatabaseWidget.cpp # src/gui/DatabaseWidget.h
|
I completed the two tasks in the original PR, request review from the team. |
TheZ3ro
reviewed
Nov 22, 2016
| #include <QLineEdit> | ||
| #include <QKeyEvent> | ||
| #include <QSplitter> | ||
| #include <QLabel> | ||
| #include <QProcess> | ||
| #include <QHeaderView> | ||
| #include <QApplication> | ||
| #include <QtDebug> |
|
Cleaned up the code you mentioned. |
TheZ3ro
approved these changes
Nov 24, 2016
Merged
* Ignore autoreload on save / save-as * Consolidated db save code * Corrected bug (crash) in merge entry code due to not cloning the entry * Enhanced known modified status of database * Implemented test cases for autoreload
b796020 to
3d24936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a simple implementation for autoreload of the database file if it is changed in the underlying file system. Includes a setting to explicitly ask to reload.
Original code written by "Sebastien Fricker" in 2014.
TODO:
Motivation and Context
Long requested feature of KeePassX, enables seamless use of cloud storage and sync tools.
How Has This Been Tested?
Manually
Types of changes
Checklist: